[ovs-git] [openvswitch/ovs] 12e468: tests/ofproto-dpif - fragment handling: Add detail...

GitHub noreply at github.com
Mon Nov 3 22:43:12 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 12e4681cfb4a7f0c85a41b347a8a89922a3e0ac2
      https://github.com/openvswitch/ovs/commit/12e4681cfb4a7f0c85a41b347a8a89922a3e0ac2
  Author: Jarno Rajahalme <jrajahalme at nicira.com>
  Date:   2014-11-03 (Mon, 03 Nov 2014)

  Changed paths:
    M tests/ofproto-dpif.at

  Log Message:
  -----------
  tests/ofproto-dpif - fragment handling: Add detail.

Add transport port modifications to the existing frags handling test
case.

This demonstrates incorrect behavior by not moving the destination
port number to source port in normal mode for first fragment, as the
transport port numbers have been zeroed and the move has no effect,
and by allowing moves to/from transport ports on later fragments
(which do not have a transport header).

Next patches fix these problems.

Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


  Commit: 5e9a47719dd02a099939f5aaada5ca3ae3b47dc3
      https://github.com/openvswitch/ovs/commit/5e9a47719dd02a099939f5aaada5ca3ae3b47dc3
  Author: Jarno Rajahalme <jrajahalme at nicira.com>
  Date:   2014-11-03 (Mon, 03 Nov 2014)

  Changed paths:
    M ofproto/ofproto-dpif-xlate.c
    M tests/ofproto-dpif.at

  Log Message:
  -----------
  ofproto-dpif-xlate: Do not clear ports with frags in xlate_actions().

Transport ports are already cleared for lookup if need be, and they
should be available for action processing, so do not clear them in
xlate_actions().

A drop flow takes care of dropping the packet, so no special case is
needed in xlate_actions().

Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>


Compare: https://github.com/openvswitch/ovs/compare/e0cc58f9b742...5e9a47719dd0


More information about the git mailing list