[ovs-git] [openvswitch/ovs] 01420a: stream-tcp: Change the connection name for pwindow...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 01420a2cddd7b5cf0a8ac59a4d60ce9d3b328d97
      https://github.com/openvswitch/ovs/commit/01420a2cddd7b5cf0a8ac59a4d60ce9d3b328d97
  Author: Gurucharan Shetty <gshetty at nicira.com>
  Date:   2014-10-02 (Thu, 02 Oct 2014)

  Changed paths:
    M lib/stream-tcp.c

  Log Message:
  -----------
  stream-tcp: Change the connection name for pwindows.

As of now, when someone passes a punix:foo/bar as a connection type
in Windows, we create a TCP server using 127.0.0.1 and save the kernel
assigned port number in the file foo/bar. The connection name
as obtained through pstream_get_name() would be ptcp:127.0.0.1:$PORT.
This was okay if pstream_get_name() was only used for logging
purposes. But netdev-dummy uses it to close active connections when the
passed name and created name are different. This causes transient
connection teardowns while using patch ports in Windows unit tests
causing occasional packet loss.

This commit sets the connection name to be punix:foo/bar instead
of ptcp:127.0.0.1:$PORT for pwindows.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>