[ovs-git] [openvswitch/ovs] ff601a: ofproto-dpif-upcall: Fix out-of-scope use of stack...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: ff601a08a44c37fa8a6e0e569dc00d6731f55555
      https://github.com/openvswitch/ovs/commit/ff601a08a44c37fa8a6e0e569dc00d6731f55555
  Author: Alex Wang <alexw at nicira.com>
  Date:   2014-10-10 (Fri, 10 Oct 2014)

  Changed paths:
    M ofproto/ofproto-dpif-upcall.c

  Log Message:
  -----------
  ofproto-dpif-upcall: Fix out-of-scope use of stack memory.

Commit cc377352d (ofproto: Reorganize in preparation for direct
dpdk upcalls.) introduced the bug that keeps reference to 'struct
flow' defined on the stack inside while loop when running out of
the scope.  This causes strange bug like wrong mask extraction
when the part of memory is corrupted, and could lead to even
more serious bug/crash.

This commit fixes the above issue by defining an array of the
'struct flow's on the function stack.

Found by running ovs on RHEL7.

Signed-off-by: Alex Wang <alexw at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>