[ovs-git] [openvswitch/ovs] 918918: netlink-socket: Always pass the output buffer in a...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 9189184d09bfb742149b878d6b9e0194979b3dbb
      https://github.com/openvswitch/ovs/commit/9189184d09bfb742149b878d6b9e0194979b3dbb
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2014-10-13 (Mon, 13 Oct 2014)

  Changed paths:
    M lib/netlink-socket.c

  Log Message:
  -----------
  netlink-socket: Always pass the output buffer in a transaction.

We need to pass down the output buffer so that the kernel can return
transaction status - error or otherwise.

Also, we were processing the output buffer only when when
'txn->reply != NULL' ie when the caller specified an ofpbuf for the
reply. In this patch, the code has been updated to process the reply
unconditionally, but making sure to copy the reply to the 'txn->reply'
only when it is not NULL. The reason for the unconditional processing is
we can pass up transactional errors in 'txn->error'. Otherwise, it
results in an endless loop of calling nl_transact().

Signed-off-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Ankur Sharma <ankursharma at vmware.com>