[ovs-git] [openvswitch/ovs] 1cf785: datapath-windows: Transactional error support in F...

GitHub noreply at github.com
Mon Oct 13 21:23:28 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 1cf78536901535d20b42e32ba71801998ddfae53
      https://github.com/openvswitch/ovs/commit/1cf78536901535d20b42e32ba71801998ddfae53
  Author: Ankur Sharma <ankursharma at vmware.com>
  Date:   2014-10-13 (Mon, 13 Oct 2014)

  Changed paths:
    M datapath-windows/ovsext/Flow.c
    M datapath-windows/ovsext/Netlink/NetlinkError.h

  Log Message:
  -----------
  datapath-windows: Transactional error support in Flow commands.

In this patch we added the code to handle transactional errors
in flow commands.

Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Nithin Raju <nithin at vmware.com
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: 34d4fea902b2b309dcfc8d25fdd309de57fe8d58
      https://github.com/openvswitch/ovs/commit/34d4fea902b2b309dcfc8d25fdd309de57fe8d58
  Author: Ankur Sharma <ankursharma at vmware.com>
  Date:   2014-10-13 (Mon, 13 Oct 2014)

  Changed paths:
    M datapath-windows/ovsext/Flow.c

  Log Message:
  -----------
  datapath-windows: Validate ETHERTYPE and ETHERNET attribute.

During vswitchd boot up kernel is receiving FLOW_ADD commands
without ETHERTYPE attribute. Added additional check for the same
in this patch. During the same phase kernel is also receiving
packet_execute with no ETHERNET attribute.

Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: c26acd5e349182b1f46cd6daa62c33f73baea621
      https://github.com/openvswitch/ovs/commit/c26acd5e349182b1f46cd6daa62c33f73baea621
  Author: Ankur Sharma <ankursharma at vmware.com>
  Date:   2014-10-13 (Mon, 13 Oct 2014)

  Changed paths:
    M datapath-windows/ovsext/Flow.c

  Log Message:
  -----------
  datapath-windows: Reply for Flow Flush.

Added changes to send a reply for FLOW_FUSH case. This is needed
as with nithin's transaction reply changes we'll need reply for each
command.

This patch also contains minor fixes for sending replies in
success case as well.

Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: 5b69dd8dafdc6ac71d4905efa6178a35bac94ade
      https://github.com/openvswitch/ovs/commit/5b69dd8dafdc6ac71d4905efa6178a35bac94ade
  Author: Ankur Sharma <ankursharma at vmware.com>
  Date:   2014-10-13 (Mon, 13 Oct 2014)

  Changed paths:
    M datapath-windows/ovsext/Flow.c

  Log Message:
  -----------
  datapath-windows: Remove setting of replyLen to zero.

This was one of the review comment which i forgot to address in
FLOW_DUMP checkin. We do not need to explicitly set replyLen to zero
 as caller would have already set it.

Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: c881751a15b6b8f17e1febd8cc86536948bc38a8
      https://github.com/openvswitch/ovs/commit/c881751a15b6b8f17e1febd8cc86536948bc38a8
  Author: Ankur Sharma <ankursharma at vmware.com>
  Date:   2014-10-13 (Mon, 13 Oct 2014)

  Changed paths:
    M datapath-windows/ovsext/Flow.c

  Log Message:
  -----------
  datapath-windows: Remove invalid assertion.

Assert(rc) would always hit for a valid case, hence
replaced it with error code based check.

Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Nithin Raju <nithin at vmware.com>
Tested-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: 2aca2188999d8986b664d4813b88c5c5823dc977
      https://github.com/openvswitch/ovs/commit/2aca2188999d8986b664d4813b88c5c5823dc977
  Author: Ankur Sharma <ankursharma at vmware.com>
  Date:   2014-10-13 (Mon, 13 Oct 2014)

  Changed paths:
    M datapath-windows/ovsext/Netlink/Netlink.c

  Log Message:
  -----------
  datapath-windows: Fix assertion in Netlink.c

NlBufAt should be called with valid boundary limits (within head and tail).
Incorrect argument to NlBufAt was leading to assert hit, fixed the same.

Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Nithin Raju <nithin at vmware.com>
Tested-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


Compare: https://github.com/openvswitch/ovs/compare/d752e0542040...2aca2188999d


More information about the git mailing list