[ovs-git] [openvswitch/ovs] eb391b: classifier: Change type used for priorities from '...

GitHub noreply at github.com
Fri Oct 31 00:42:50 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: eb391b76aff9639547312ab93bdac9cc2e76c119
      https://github.com/openvswitch/ovs/commit/eb391b76aff9639547312ab93bdac9cc2e76c119
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2014-10-30 (Thu, 30 Oct 2014)

  Changed paths:
    M lib/classifier-private.h
    M lib/classifier.c
    M lib/classifier.h
    M lib/match.c
    M lib/match.h
    M lib/ofp-util.h
    M lib/pvector.c
    M lib/pvector.h
    M ofproto/in-band.c
    M ofproto/ofproto-provider.h
    M ofproto/ofproto.c
    M tests/test-classifier.c
    M utilities/ovs-ofctl.c

  Log Message:
  -----------
  classifier: Change type used for priorities from 'unsigned int' to 'int'.

OpenFlow has priorities in the 16-bit unsigned range, from 0 to 65535.
In the classifier, it is sometimes useful to be able to have values below
and above this range.  With the 'unsigned int' type used for priorities
until now, there were no values below the range, so some code worked
around it by converting priorities to 64-bit signed integers.  This didn't
seem so great to me given that a plain 'int' also had the needed range.
This commit therefore changes the type used for priorities to int.

The interesting parts of this change are in pvector.h and classifier.c,
where one can see the elimination of the use of int64_t.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>




More information about the git mailing list