[ovs-git] [openvswitch/ovs] d12f12: ofp-errors: Fix bugs in treatment of OpenFlow expe...

GitHub noreply at github.com
Thu Sep 4 19:35:21 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: d12f128a31210ed936820cea68c2f42c07ead5cf
      https://github.com/openvswitch/ovs/commit/d12f128a31210ed936820cea68c2f42c07ead5cf
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2014-09-04 (Thu, 04 Sep 2014)

  Changed paths:
    M build-aux/extract-ofp-errors
    M lib/ofp-errors.h
    M tests/ofp-errors.at

  Log Message:
  -----------
  ofp-errors: Fix bugs in treatment of OpenFlow experimenter errors.

OpenFlow 1.2 and later have "experimenter errors".  The OVS implementation
was buggy in a few ways.  First, a bug in extract-ofp-errors prevented
OF1.2+ experimenter errors from being properly decoded.  Second,
OF1.2+ experimenter errors have only a type, not a code, whereas all other
types of errors (standard errors, OF1.0/1.1 Nicira extension errors) have
both, but extract-ofp-errors didn't properly enforce that.

This commit fixes both problems and improves existing tests to verify that
encoding and decoding of experimenter errors now works properly.

This commit also fixes the definition of OFPBIC_DUP_INST.  It claimed to
have an OF1.1 experimenter error value although OF1.1 didn't have
experimenter errors.  This commit changes it to use a Nicira extension
error in OF1.1 instead.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>


  Commit: 6b2dfe8e9f575f21faae2538f10bc2be8b5cf09e
      https://github.com/openvswitch/ovs/commit/6b2dfe8e9f575f21faae2538f10bc2be8b5cf09e
  Author: Jean Tourrilhes <jt at hpl.hp.com>
  Date:   2014-09-04 (Thu, 04 Sep 2014)

  Changed paths:
    M lib/ofp-errors.h

  Log Message:
  -----------
  ofp-errors: Migrate EXT-444 errors to ONF experimenter ID.

Signed-off-by: Jean Tourrilhes <jt at hpl.hp.com>
[blp at nicira.com removed the definitions of these errors in OF1.1 and OF1.2]
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>


Compare: https://github.com/openvswitch/ovs/compare/a678b23e6660...6b2dfe8e9f57


More information about the git mailing list