[ovs-git] [openvswitch/ovs] 81fed0: datapath-windows: Data structures and functions fo...

GitHub noreply at github.com
Thu Sep 4 19:41:37 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 81fed0452f46bbd3a1a77aeddb8bb4983a82baee
      https://github.com/openvswitch/ovs/commit/81fed0452f46bbd3a1a77aeddb8bb4983a82baee
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2014-09-04 (Thu, 04 Sep 2014)

  Changed paths:
    M datapath-windows/ovsext/Datapath.h

  Log Message:
  -----------
  datapath-windows: Data structures and functions for dump state

Signed-off-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Saurabh Shah <ssaurabh at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: a19f14a74d7efcde7116e95051cbc28d3ee9984b
      https://github.com/openvswitch/ovs/commit/a19f14a74d7efcde7116e95051cbc28d3ee9984b
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2014-09-04 (Thu, 04 Sep 2014)

  Changed paths:
    M datapath-windows/ovsext/Datapath.c

  Log Message:
  -----------
  datapath-windows: make NL version a UIN8 and add a validateDp arg

I didn't realize earlier that version in a netlink message was a
UINT8. So, fixing that here.

Also, some of the commands don't pass a valid DP value. Hence adding
a field to identify such commands.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Saurabh Shah <ssaurabh at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: e4bd84f36b5670b8f394c8bb5170a85aed9b5901
      https://github.com/openvswitch/ovs/commit/e4bd84f36b5670b8f394c8bb5170a85aed9b5901
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2014-09-04 (Thu, 04 Sep 2014)

  Changed paths:
    M datapath-windows/ovsext/Datapath.c
    M datapath-windows/ovsext/Datapath.h

  Log Message:
  -----------
  datapath-windows: add a context structure for user parameters

In this patch we add a context structure for collecting all the parameters
passed from usersapce in one place. The idea is to reduce the number of
parameters being passed to the netlink command handler functions.

It can be argued that not all functions require all the arguments, but this
approach keeps the code clean, IMO.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Saurabh Shah <ssaurabh at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: 63520eeb2b1942a764f0668164d4c2df8c2f9741
      https://github.com/openvswitch/ovs/commit/63520eeb2b1942a764f0668164d4c2df8c2f9741
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2014-09-04 (Thu, 04 Sep 2014)

  Changed paths:
    M datapath-windows/ovsext/Datapath.c

  Log Message:
  -----------
  datapath-windows: add support for GET_DP command to dump datpaths

In this patch, we add support for the GET_DP netlink command to dump
the datpaaths. The userspace workflow to get this to work is the same
as on Linux. dpif-linux.c initiates a dump start by writing a netlink
message, and after that continues to read data from the kernel while
the kernel has data. The state is maintained in the kernel, and not in
userspace. This approach was taken since there was not great benefit
of maintaining state in userspace, and also to avoid userspace changes
specific to Windows.

This hopefully serves as a template to base the other dump commands on.

validation:
- With a hacked up dpif-linux.c to work on Windows,
  dpif_linux_enumerate() successfully enumerated the datapaths in the
  kernel.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Ankur Sharma <ankursharma at vmware.com>
Acked-by: Saurabh Shah <ssaurabh at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


Compare: https://github.com/openvswitch/ovs/compare/6b2dfe8e9f57...63520eeb2b19


More information about the git mailing list