[ovs-git] [openvswitch/ovs] 2252cb: AUTHORS: Add Ariel Tubaltsev to AUTHORS.

GitHub noreply at github.com
Thu Sep 4 22:58:51 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 2252cbea780f0981911ea0998a1e4d6ec8bbbf78
      https://github.com/openvswitch/ovs/commit/2252cbea780f0981911ea0998a1e4d6ec8bbbf78
  Author: Gurucharan Shetty <gshetty at nicira.com>
  Date:   2014-09-04 (Thu, 04 Sep 2014)

  Changed paths:
    M AUTHORS

  Log Message:
  -----------
  AUTHORS: Add Ariel Tubaltsev to AUTHORS.

I missed it while adding commit 6ee1400bbff(vtep: additions to BFD
configuration and status reporting)

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>


  Commit: ec2d2b5f03913f262a11c23f3e9b2a9e30157139
      https://github.com/openvswitch/ovs/commit/ec2d2b5f03913f262a11c23f3e9b2a9e30157139
  Author: Gurucharan Shetty <gshetty at nicira.com>
  Date:   2014-09-04 (Thu, 04 Sep 2014)

  Changed paths:
    M lib/automake.mk
    A lib/ovs-atomic-msvc.h
    M lib/ovs-atomic.h

  Log Message:
  -----------
  ovs-atomics: Add atomic support Windows.

Before this change (i.e., with pthread locks for atomics on Windows),
the benchmark for cmap and hmap was as follows:

$ ./tests/ovstest.exe test-cmap benchmark 10000000 3 1
Benchmarking with n=10000000, 3 threads, 1.00% mutations:
cmap insert:  61070 ms
cmap iterate:  2750 ms
cmap search:  14238 ms
cmap destroy:  8354 ms

hmap insert:   1701 ms
hmap iterate:   985 ms
hmap search:   3755 ms
hmap destroy:  1052 ms

After this change, the benchmark is as follows:
$ ./tests/ovstest.exe test-cmap benchmark 10000000 3 1
Benchmarking with n=10000000, 3 threads, 1.00% mutations:
cmap insert:   3666 ms
cmap iterate:   365 ms
cmap search:   2016 ms
cmap destroy:  1331 ms

hmap insert:   1495 ms
hmap iterate:  1026 ms
hmap search:   4167 ms
hmap destroy:  1046 ms

So there is clearly a big improvement for cmap.

But the correspondig test on Linux (with gcc 4.6) yeilds the following:

./tests/ovstest test-cmap benchmark 10000000 3 1
Benchmarking with n=10000000, 3 threads, 1.00% mutations:
cmap insert:   3917 ms
cmap iterate:   355 ms
cmap search:    871 ms
cmap destroy:  1158 ms

hmap insert:   1988 ms
hmap iterate:  1005 ms
hmap search:   5428 ms
hmap destroy:   980 ms

So for this particular test, except for "cmap search", Windows and
Linux have similar performance. Windows is around 2.5x slower in "cmap search"
compared to Linux. This has to be investigated.

Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>
[With a lot of inputs and help from Jarno]
Signed-off-by: Jarno Rajahalme <jrajahalme at nicira.com>


Compare: https://github.com/openvswitch/ovs/compare/63520eeb2b19...ec2d2b5f0391


More information about the git mailing list