[ovs-git] [openvswitch/ovs] 9c7e02: ovs-rcu: Make ovsrcu_quiesce() flush the callback ...
GitHub
noreply at github.com
Fri Sep 12 17:28:00 UTC 2014
Branch: refs/heads/master
Home: https://github.com/openvswitch/ovs
Commit: 9c7e020fd60baa98528bd202caeb9e908b036216
https://github.com/openvswitch/ovs/commit/9c7e020fd60baa98528bd202caeb9e908b036216
Author: Alex Wang <alexw at nicira.com>
Date: 2014-09-12 (Fri, 12 Sep 2014)
Changed paths:
M lib/ovs-rcu.c
Log Message:
-----------
ovs-rcu: Make ovsrcu_quiesce() flush the callback event set.
On current master, the per-thread callback event set is flushed
when ovsrcu_quiesce_start() is called or when the callback
event set is full. For threads that only call 'ovsrcu_quiesce()'
to indicate quiescient state, their callback event set will not
be flushed for execution until the set is full. And this could
take a very long time.
Theoretically, this should not be an issue, since rcu postponed
callback events should only free the old version of objects.
However, current ovs does not follow this rule, and some callback
events include other activities like unregistering the netdev
from global name-netdev map. The delay of unregistering the netdev
(by threads that only calls ovsrcu_quiesce()) will prevent the
recreate of same netdev indefinitely.
As a short-term workaround, this commit makes every call to
ovsrcu_quiesce() flush the callback event set. In the long run,
there will be a refactor of the use of ovs-rcu module, in which all
callback events only free the old version of objects.
Signed-off-by: Alex Wang <alexw at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>
More information about the git
mailing list