[ovs-git] [openvswitch/ovs] 884c47: datapath-windows: fix bug in NlBufCopyAtTailUninit

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 884c477fa87ee42f46937160caa35f3f983fe35c
      https://github.com/openvswitch/ovs/commit/884c477fa87ee42f46937160caa35f3f983fe35c
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2014-09-16 (Tue, 16 Sep 2014)

  Changed paths:
    M datapath-windows/ovsext/Netlink/NetlinkBuf.c

  Log Message:
  -----------
  datapath-windows: fix bug in NlBufCopyAtTailUninit

We should be returning value of tail before the increment
and not after.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Ankur Sharma <ankursharma at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: 3245c4986b9396b130e42fbb7fe72e53733c1d53
      https://github.com/openvswitch/ovs/commit/3245c4986b9396b130e42fbb7fe72e53733c1d53
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2014-09-16 (Tue, 16 Sep 2014)

  Changed paths:
    M datapath-windows/include/OvsDpInterfaceExt.h
    M datapath-windows/ovsext/Datapath.c

  Log Message:
  -----------
  datapath-windows: use the Netlink set API and need new APIs

In this change:
1. we refactor the code that fills up information about the DP into
a seprate function.
2. use the netlink set APIs to fill up the netlink attributes.
3. we define a OVS_DP_STATS to be a typedef of 'struct ovs_dp_stats'
in keeping with the Windows kernel naming conventions.
4. In the absence of netlink set API, I had put in an ASSERT earlier
that the output buffer should be limited to 512 bytes. This is not
true anymore. The netlink set API checks for bounds of the buffer.
Hence removed the ASSERT.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Ankur Sharma <ankursharma at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


Compare: https://github.com/openvswitch/ovs/compare/5e2a670201c9...3245c4986b93