[ovs-git] [openvswitch/ovs] f6d0d4: netdev: Fix error check.

GitHub noreply at github.com
Thu Sep 25 21:18:05 UTC 2014


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: f6d0d4b3d0d0a2cdc4740ebe3bcf091508e62492
      https://github.com/openvswitch/ovs/commit/f6d0d4b3d0d0a2cdc4740ebe3bcf091508e62492
  Author: Alex Wang <alexw at nicira.com>
  Date:   2014-09-25 (Thu, 25 Sep 2014)

  Changed paths:
    M lib/netdev.c

  Log Message:
  -----------
  netdev: Fix error check.

Reported-by: Daniel Badea <daniel.badea at windriver.com>
Signed-off-by: Alex Wang <alexw at nicira.com>
Acked-by: Daniele Di Proietto <ddiproietto at vmware.com>


  Commit: 1b7a04e05b6fd15fb4caa7ec20d09ba7aa73399f
      https://github.com/openvswitch/ovs/commit/1b7a04e05b6fd15fb4caa7ec20d09ba7aa73399f
  Author: Alex Wang <alexw at nicira.com>
  Date:   2014-09-25 (Thu, 25 Sep 2014)

  Changed paths:
    M AUTHORS
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Fix crash when there is no pci numa info.

When kernel cannot obtain the pci numa info, the numa_node file
in corresponding pci directory in sysfs will show -1.  Then the
rte_eth_dev_socket_id() function will return it to ovs.  On
current master, ovs assumes rte_eth_dev_socket_id() always
returns non-negative value.  So using this -1 in pmd thread
creation will cause ovs crash.

To fix the above issue, this commit makes ovs always check the
return value of rte_eth_dev_socket_id() and use numa node 0 if
the return value is negative.

Reported-by: Daniel Badea <daniel.badea at windriver.com>
Signed-off-by: Alex Wang <alexw at nicira.com>
Acked-by: Daniele Di Proietto <ddiproietto at vmware.com>


Compare: https://github.com/openvswitch/ovs/compare/dced21add6ff...1b7a04e05b6f


More information about the git mailing list