[ovs-git] [openvswitch/ovs] e00afc: datapath-windows: fix OVS_VPORT_TYPE

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: e00afcf6427ab3b99c6ad0867c2a22bfe9ead180
      https://github.com/openvswitch/ovs/commit/e00afcf6427ab3b99c6ad0867c2a22bfe9ead180
  Author: Samuel Ghinet <sghinet at cloudbasesolutions.com>
  Date:   2014-09-26 (Fri, 26 Sep 2014)

  Changed paths:
    M datapath-windows/include/OvsDpInterfaceExt.h
    M datapath-windows/include/OvsPub.h
    M datapath-windows/ovsext/Actions.c
    M datapath-windows/ovsext/Tunnel.c
    M datapath-windows/ovsext/Vport.c
    M datapath-windows/ovsext/Vport.h
    M datapath-windows/ovsext/Vxlan.c
    M datapath-windows/ovsext/precomp.h

  Log Message:
  -----------
  datapath-windows: fix OVS_VPORT_TYPE

The windows ovs kernel uses an OVS_VPORT_TYPE enum that is incompatible with
the userspace counterpart (enum ovs_vport_type from openvswitch.h). We must use
the same enum type for the netlink communication to work properly.

This patch makes the fix: "typedef enum ovs_vport_type OVS_VPORT_TYPE" and
changes the afferent kernel driver code:
o) vport types synthetic and emulated turn to: netdev
o) vport type internal turns to: internal
o) vport type external truns to: netdev (plus, we hold a field in vport,
"isExternal"

Signed-off-by: Samuel Ghinet <sghinet at cloudbasesolutions.com>
Acked-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: 17c6a05f08a7570dba05a171b08068a71966f11f
      https://github.com/openvswitch/ovs/commit/17c6a05f08a7570dba05a171b08068a71966f11f
  Author: Samuel Ghinet <sghinet at cloudbasesolutions.com>
  Date:   2014-09-26 (Fri, 26 Sep 2014)

  Changed paths:
    M datapath-windows/ovsext/Datapath.c
    M datapath-windows/ovsext/Vport.h

  Log Message:
  -----------
  datapath-windows: Implement vport dump Netlink command.

Functionality for vport dump.
Later, when we will add more netlink dump commands, some common code will need
to be split to functions.

Notes:
a) the current implementation of vport assumes the datapath feature
"multiple upcall pids" is not used. A single upcall pid is used now.
c) the vxlan destination udp port is currently a constant. When it will become
configurable, the vport options netlink attribute will become relevant.

Signed-off-by: Samuel Ghinet <sghinet at cloudbasesolutions.com>
Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Acked-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: fce695e6f71d8de1329b917d8b94718a0ffc9284
      https://github.com/openvswitch/ovs/commit/fce695e6f71d8de1329b917d8b94718a0ffc9284
  Author: Samuel Ghinet <sghinet at cloudbasesolutions.com>
  Date:   2014-09-26 (Fri, 26 Sep 2014)

  Changed paths:
    M datapath-windows/automake.mk
    M datapath-windows/ovsext/Datapath.c
    M datapath-windows/ovsext/Datapath.h
    A datapath-windows/ovsext/Netlink/NetlinkError.h
    M datapath-windows/ovsext/Netlink/NetlinkProto.h
    M datapath-windows/ovsext/ovsext.vcxproj
    M datapath-windows/ovsext/precomp.h

  Log Message:
  -----------
  datapath-windows: Add file NetlinkError.h.

Contains error codes for netlink transactional errors.
These errors are passed to the "error" field (INT) of the NL_MSG_ERR struct.
The userspace requires them to be negative values: the nl_msg_nlmsgerr userspace
function transforms them from negative to positive values.

These error codes correspond to the userspace error codes defined in:
"C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\include\errno.h"

Signed-off-by: Samuel Ghinet <sghinet at cloudbasesolutions.com>
Acked-by: Eitan Eliahu <eliahue at vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: 5b08d39a6da1bb746a0691fa7cfcaafe9a1cef67
      https://github.com/openvswitch/ovs/commit/5b08d39a6da1bb746a0691fa7cfcaafe9a1cef67
  Author: Samuel Ghinet <sghinet at cloudbasesolutions.com>
  Date:   2014-09-26 (Fri, 26 Sep 2014)

  Changed paths:
    M datapath-windows/ovsext/Datapath.c

  Log Message:
  -----------
  datapath-windows: Add Netlink vport command get.

The transactional get vport command.
This command uses the netlink transactional errors.

Signed-off-by: Samuel Ghinet <sghinet at cloudbasesolutions.com>
Acked-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


Compare: https://github.com/openvswitch/ovs/compare/260f76b7e3cf...5b08d39a6da1