[ovs-git] [openvswitch/ovs] 8dba24: ofproto-dpif-rid: correct logic error in rid_pool_...

GitHub noreply at github.com
Fri Sep 26 18:37:47 UTC 2014


  Branch: refs/heads/branch-2.3
  Home:   https://github.com/openvswitch/ovs
  Commit: 8dba24782fa8a9786184cb24718abbd28e115dd6
      https://github.com/openvswitch/ovs/commit/8dba24782fa8a9786184cb24718abbd28e115dd6
  Author: Simon Horman <simon.horman at netronome.com>
  Date:   2014-09-26 (Fri, 26 Sep 2014)

  Changed paths:
    M ofproto/ofproto-dpif-rid.c

  Log Message:
  -----------
  ofproto-dpif-rid: correct logic error in rid_pool_alloc_id()

When searching through the valid ids an id should
be used if is not found rather than if it is found.

It appears to me that without this change duplicate recirculation
ids may used in cases where the last recirculation id has
been allocated; selection loops back to the beginning of the pool and;
reaches a recirculation id that is still in use.

As the number of recirculation ids is currently RECIRC_ID_N_IDS = 1024 this
does not seem beyond the bounds of possibility.

I have not verified that such a scenario can actually occur.  But it seems
that a likely consequence would be that some packets may be forwarded
incorrectly.

Signed-off-by: Simon Horman <simon.horman at netronome.com>
Signed-off-by: Andy Zhou <azhou at nicira.com>




More information about the git mailing list