[ovs-git] [openvswitch/ovs] b3cceb: bridge: Execute bridge_run() only after retrieving...

GitHub noreply at github.com
Thu Apr 2 00:05:42 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: b3cceba0b7c4013f46b01f8987e8716d7857c6db
      https://github.com/openvswitch/ovs/commit/b3cceba0b7c4013f46b01f8987e8716d7857c6db
  Author: Alex Wang <alexw at nicira.com>
  Date:   2015-04-01 (Wed, 01 Apr 2015)

  Changed paths:
    M vswitchd/bridge.c

  Log Message:
  -----------
  bridge: Execute bridge_run() only after retrieving db contents.

During upgrade of ovs-vswitchd, we do not want to recreate the already
configured kernel interfaces.  Especially when IP address is assigned to
the internal port, the recreation will cause the lost of connection.
Therefore, ovs-vswitchd should read current ovsdb content first and then
reuse the existing kernel interfaces that are configured in ovsdb.  In
terms of the code language, ovs-vswitchd should only execute bridge_run()
after it finishes reading the ovsdb content.

However, this expected behavior is broken by the recent commit d18e52e
(ovsdb-idl: Tolerate missing tables and columns.) which causes the
execution of bridge_run() before getting the hint of configured interfaces
from ovsdb.

To fix the issue, this commit makes sure that the execution of bridge_run()
happens only after retrieving the ovsdb contents.

VMware-BZ: #1424342

Signed-off-by: Alex Wang <alexw at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>




More information about the git mailing list