[ovs-git] [openvswitch/ovs] 416e71: acinclude: Always assume buggy strtok_r() for glib...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 416e71322f82beea869b2e5928be5ae60f2577de
      https://github.com/openvswitch/ovs/commit/416e71322f82beea869b2e5928be5ae60f2577de
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-04-03 (Fri, 03 Apr 2015)

  Changed paths:
    M acinclude.m4

  Log Message:
  -----------
  acinclude: Always assume buggy strtok_r() for glibc < 2.8.

Lately our internal build system has been seeing intermittent failures that
I can't explain.  With old glibc versions, the "configure" time check will
pass, but the equivalent (almost identical) "make check" test will fail.
One possibility, I guess, is that occasionally address space randomization
will put valid data at the 0xc0ffee address that the test assumes will
segfault, and another is that some change in compiler optimization flags
is making a difference.  At any rate, I think it's safe to just always
assume that this strtok_r() bug is present whenever glibc before 2.8 is
in use.

Specifically we've seen this happen intermittently when building against
the XenServer DDK 5.6.100 build 39265, which uses glibc 2.5.

Reported-by: Alex Wang <alexw at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Alex Wang <alexw at nicira.com>