[ovs-git] [openvswitch/ovs] 79ae21: dpctl: Fix error handling and reporting regression...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 79ae214d2d93e4ae584455db0cc0e054b76cc711
      https://github.com/openvswitch/ovs/commit/79ae214d2d93e4ae584455db0cc0e054b76cc711
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-04-16 (Thu, 16 Apr 2015)

  Changed paths:
    M lib/dpctl.c

  Log Message:
  -----------
  dpctl: Fix error handling and reporting regressions.

Fixes multiple weaknesses in dpctl error reporting:

    * dpctl_set_if() didn't stop processing or report to the caller
      attempts to change a port type or number.

    * dpctl_set_if() didn't report the specifics when netdev_set_config()
      reported an error setting port configuration (which can happen even
      it returns 0).

    * The unixctl handler didn't report errors encountered during command
      processing through the JSON-RPC error mechanism, which meant that
      ovs-appctl's return code wasn't useful (as ovs-dpctl's return code
      is useful) for detecting errors in command execution.

At least the first of these is a regression from OVS 2.3.x.

A followup commit will add tests.

Reported-by: Kevin Lo <kevlo at FreeBSD.org>
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Daniele Di Proietto <diproiettod at vmware.com>


  Commit: 17050610ec44820dca59c3bfa617f55d3add2cfc
      https://github.com/openvswitch/ovs/commit/17050610ec44820dca59c3bfa617f55d3add2cfc
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-04-16 (Thu, 16 Apr 2015)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Reject adding duplicate ports.

Otherwise it is at least very confusing.

Found during testing.  An upcoming commit adds a test.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Daniele Di Proietto <diproiettod at vmware.com>


  Commit: 5acf2e916a830e4b93eaf18cce5cced9a2a1ab5d
      https://github.com/openvswitch/ovs/commit/5acf2e916a830e4b93eaf18cce5cced9a2a1ab5d
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-04-16 (Thu, 16 Apr 2015)

  Changed paths:
    M tests/automake.mk
    A tests/dpctl.at
    M tests/dpif-netdev.at
    M tests/testsuite.at

  Log Message:
  -----------
  dpctl: Add tests.

These tests prevent regressions against the problems fixed by the previous
two commits.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Daniele Di Proietto <diproiettod at vmware.com>


Compare: https://github.com/openvswitch/ovs/compare/f097013adabf...5acf2e916a83