[ovs-git] [openvswitch/ovs] fc3113: ovn-nbd: Match bindings on lport name.

[GitHub]

  Branch: refs/heads/ovn
  Home:   https://github.com/openvswitch/ovs
  Commit: fc3113bcb8ff07ae97d2f22150454f723849d675
      https://github.com/openvswitch/ovs/commit/fc3113bcb8ff07ae97d2f22150454f723849d675
  Author: Russell Bryant <rbryant at redhat.com>
  Date:   2015-04-16 (Thu, 16 Apr 2015)

  Changed paths:
    M ovn/ovn-nbd.c

  Log Message:
  -----------
  ovn-nbd: Match bindings on lport name.

When ovn-nbd is looking through bindings to figure out if any logical
ports in the northbound DB need to have their 'up' state changed, it
should be using the logical port's name instead of UUID for matching
up to rows in the OVN db.

The switch to using the name instead of UUID means we don't have a
quick lookup so we use the same approach that's used for handling
updates in the other direction.  We start by hashing all of the
logical ports by name.  As we iterate through the bindings, we can
then look up ports by name quickly.

Signed-off-by: Russell Bryant <rbryant at redhat.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: cf1486e00425999e7244656047c1b23ef6fc7708
      https://github.com/openvswitch/ovs/commit/cf1486e00425999e7244656047c1b23ef6fc7708
  Author: Russell Bryant <rbryant at redhat.com>
  Date:   2015-04-16 (Thu, 16 Apr 2015)

  Changed paths:
    M ovn/ovn-nbd.c

  Log Message:
  -----------
  ovn-nbd: Don't shadow hash_node variable.

This variable is already defined at the top of the function, so just
reuse that instead of defining it again.

Signed-off-by: Russell Bryant <rbryant at redhat.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: 1d4e6b55b50ce8455ff94593f18ef84a25a24680
      https://github.com/openvswitch/ovs/commit/1d4e6b55b50ce8455ff94593f18ef84a25a24680
  Author: Russell Bryant <rbryant at redhat.com>
  Date:   2015-04-16 (Thu, 16 Apr 2015)

  Changed paths:
    M ovn/ovn-nbd.c

  Log Message:
  -----------
  ovn-nbd: Fix unsafe HMAP_FOR_EACH_WITH_HASH usage.

The previous code assumed that hash_node would be NULL when the loop
terminated without a match.  That's not the case, so track the match a
little differently.

Signed-off-by: Russell Bryant <rbryant at redhat.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


Compare: https://github.com/openvswitch/ovs/compare/f386a8a7583f...1d4e6b55b50c