[ovs-git] [openvswitch/ovs] 9ff55a: dpif-netdev: Store actions data and size contiguou...

GitHub noreply at github.com
Mon Apr 20 19:49:49 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 9ff55ae284809bd63fe1c9c9a90b1733193e76cd
      https://github.com/openvswitch/ovs/commit/9ff55ae284809bd63fe1c9c9a90b1733193e76cd
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2015-04-20 (Mon, 20 Apr 2015)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Store actions data and size contiguously.

As stated by the comment above the structure, the 'action' pointer does not
change during the 'dp_netdev_actions' lifetime: we might as well embed
the pointed memory into the structure.

The commit also updates the description of dp_netdev_actions_create().

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


  Commit: 11bfdaddf2035efe054b6a098dc3b8aeeb65eeb6
      https://github.com/openvswitch/ovs/commit/11bfdaddf2035efe054b6a098dc3b8aeeb65eeb6
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2015-04-20 (Mon, 20 Apr 2015)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Cache time_msec() calls for each received batch.

Calling time_msec() (which calls clock_gettime()) too often might be
expensive.  With this commit OVS makes only one call per received
batch and caches the result.

Suggested-by: Ethan Jackson <ethan at nicira.com>
Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


  Commit: 2bc1bbd27ded5752f438ff35673f38a527ea0915
      https://github.com/openvswitch/ovs/commit/2bc1bbd27ded5752f438ff35673f38a527ea0915
  Author: Daniele Di Proietto <diproiettod at vmware.com>
  Date:   2015-04-20 (Mon, 20 Apr 2015)

  Changed paths:
    M lib/dp-packet.h
    M lib/dpif-netdev.c
    M lib/netdev-bsd.c
    M lib/netdev-dummy.c
    M lib/netdev-linux.c
    M lib/netdev-vport.c
    M lib/odp-execute.c

  Log Message:
  -----------
  dp-packet: Rename 'dp_hash' in 'rss_hash'.

We already have the 'dp_hash' embedded in the metadata.  This caused
confusion in the code.  With this commit it should be clear that
'rss_hash' is the packet hash used for internal purposes, while
'md.dp_hash' is part of the flow, computed during the execution of
certain actions.

Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Acked-by: Ethan Jackson <ethan at nicira.com>


Compare: https://github.com/openvswitch/ovs/compare/b937e116da2c...2bc1bbd27ded


More information about the git mailing list