[ovs-git] [openvswitch/ovs] cc5dba: flow: Ignore invalid ICMPv6 fields when parsing pa...

GitHub noreply at github.com
Thu Aug 13 21:48:10 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: cc5dba2f32b12b9e887c94a2dd8a765be1a48818
      https://github.com/openvswitch/ovs/commit/cc5dba2f32b12b9e887c94a2dd8a765be1a48818
  Author: Simon Horman <simon.horman at netronome.com>
  Date:   2015-08-13 (Thu, 13 Aug 2015)

  Changed paths:
    M lib/flow.c

  Log Message:
  -----------
  flow: Ignore invalid ICMPv6 fields when parsing packets

There is a miss-match between the handling of invalid ICMPv6 fields in the
implementations of parse_icmpv6() in user-space and in the kernel datapath.

This patch addresses that by modifying the user-space implementation to
match that of the kernel datapath; processing is terminated without
rather than with an error and partial information is cleared.

With these changes the user-space implementation of parse_icmpv6()
never returns an error. Accordingly the return type and caller have been
updated.

The original motivation for this is to allow matching the ICMPv6 type and
code of packets with invalid neighbour discovery options although only the
change around the '(!opt_len || opt_len > *sizep)' conditional is necessary
to achieve that goal.

Signed-off-by: Simon Horman <simon.horman at netronome.com>
Signed-off-by: Jesse Gross <jesse at nicira.com>




More information about the git mailing list