[ovs-git] [openvswitch/ovs] 290ead: ofp-util: Use correct error for indirect group wit...

GitHub noreply at github.com
Thu Aug 20 00:42:06 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 290eada707b81319b00bc23f7451fdd96e786210
      https://github.com/openvswitch/ovs/commit/290eada707b81319b00bc23f7451fdd96e786210
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-08-19 (Wed, 19 Aug 2015)

  Changed paths:
    M lib/ofp-util.c

  Log Message:
  -----------
  ofp-util: Use correct error for indirect group with more than one bucket.

OpenFlow 1.5 says:

    If the group-mod request specifies more than one bucket for a group of
    type Indirect, the switch must refuse to add the group entry and must
    send an ofp_error_msg with OFPET_GROUP_MOD_FAILED type and
    OFPGMFC_INVALID_GROUP code.

Older versions don't specify a particular error for this case, so we might
as well use it for older OpenFlow also.

Found by OFTest.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Jarno Rajahalme <jrajahalme at nicira.com>




More information about the git mailing list