[ovs-git] [openvswitch/ovs] 2234a7: tun-metadata: Always set option present when copyi...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 2234a7db33539500dc439a41243b70083f28ba54
      https://github.com/openvswitch/ovs/commit/2234a7db33539500dc439a41243b70083f28ba54
  Author: Jesse Gross <jesse at nicira.com>
  Date:   2015-08-21 (Fri, 21 Aug 2015)

  Changed paths:
    M lib/tun-metadata.c
    M tests/tunnel-push-pop.at

  Log Message:
  -----------
  tun-metadata: Always set option present when copying data.

Whenever we write into a tunnel option field, we also need to mark
it as significant. If we don't, then the data will later be ignored.

We currently do this in every case except for flow metadata. This causes
us to not correctly serialize the tunnel metadata for Packet Ins to the
controller.

Rather than separately writing the data and marking the options as present,
it is better to combine the two steps to ensure that one can never be
done without the other.

Signed-off-by: Jesse Gross <jesse at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>