[ovs-git] [openvswitch/ovs] eeb034: datapath: Fix STT packet receive handling.

GitHub noreply at github.com
Fri Dec 11 04:38:02 UTC 2015


  Branch: refs/heads/branch-2.5
  Home:   https://github.com/openvswitch/ovs
  Commit: eeb03435705ea38a82bd5aa39a6f27b559ce3c64
      https://github.com/openvswitch/ovs/commit/eeb03435705ea38a82bd5aa39a6f27b559ce3c64
  Author: Pravin B Shelar <pshelar at nicira.com>
  Date:   2015-12-10 (Thu, 10 Dec 2015)

  Changed paths:
    M datapath/linux/compat/stt.c

  Log Message:
  -----------
  datapath: Fix STT packet receive handling.

STT reassembly can generate list of packets. But it was
handled as a single skb. Following patch fixes it.

Fixes: e23775f20 ("datapath: Add support for lwtunnel").
Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
Acked-by: Jesse Gross <jesse at kernel.org>
Acked-by: Joe Stringer <joe at ovn.org>


  Commit: 176752aa6ad49e1a3c074881c0f1a9569bcba209
      https://github.com/openvswitch/ovs/commit/176752aa6ad49e1a3c074881c0f1a9569bcba209
  Author: Pravin B Shelar <pshelar at nicira.com>
  Date:   2015-12-10 (Thu, 10 Dec 2015)

  Changed paths:
    M datapath/linux/compat/include/linux/skbuff.h

  Log Message:
  -----------
  datapath: Backport: skbuff: Fix skb checksum partial check.

This bug fix is not required for OVS use cases. But is it
nice to keep function consistent with upstream implementation.

Upstream commit:

    Earlier patch 6ae459bda tried to detect void ckecksum partial
    skb by comparing pull length to checksum offset. But it does
    not work for all cases since checksum-offset depends on
    updates to skb->data.

    Following patch fixes it by validating checksum start offset
    after skb-data pointer is updated. Negative value of checksum
    offset start means there is no need to checksum.

    Fixes: 6ae459bda ("skbuff: Fix skb checksum flag on skb pull")
    Reported-by: Andrew Vagin <avagin at odin.com>
    Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
    Signed-off-by: David S. Miller <davem at davemloft.net>

Upstream: 31b33dfb0a1 ("skbuff: Fix skb checksum partial check");
Signed-off-by: Pravin B Shelar <pshelar at nicira.com>
Acked-by: Jesse Gross <jesse at kernel.org>


Compare: https://github.com/openvswitch/ovs/compare/310385320792...176752aa6ad4


More information about the git mailing list