[ovs-git] [openvswitch/ovs] 896313: ofp-util: return BAD_TYPE for consistency at ofput...

GitHub noreply at github.com
Wed Dec 23 00:49:01 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 896313f3f7d9ac1f97b8127b5a37383bf490f014
      https://github.com/openvswitch/ovs/commit/896313f3f7d9ac1f97b8127b5a37383bf490f014
  Author: Flavio Leitner <fbl at redhat.com>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M lib/ofp-util.c

  Log Message:
  -----------
  ofp-util: return BAD_TYPE for consistency at ofputil_decode_group_mod().

Code earlier in this function validated that gm->type is valid, so
the default case at the end of the function would be impossible, but
since the code can change or perhaps get copied, return the correct
error to keep consistency and avoid reintroducing the bug fixed by
commit 09d4b951636b ("ofp-util: Reject bad group type and command
with error instead of abort.")

Signed-off-by: Flavio Leitner <fbl at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>




More information about the git mailing list