[ovs-git] [openvswitch/ovs] 047bfa: ofp-actions: Add padding in ofpacts_pull_openflow_...

GitHub noreply at github.com
Wed Dec 23 07:11:20 UTC 2015


  Branch: refs/heads/branch-2.3
  Home:   https://github.com/openvswitch/ovs
  Commit: 047bfa263a377f4b89125ba0f311c4e94e94f60a
      https://github.com/openvswitch/ovs/commit/047bfa263a377f4b89125ba0f311c4e94e94f60a
  Author: William Tu <u9012063 at gmail.com>
  Date:   2015-12-22 (Tue, 22 Dec 2015)

  Changed paths:
    M lib/ofp-actions.c

  Log Message:
  -----------
  ofp-actions: Add padding in ofpacts_pull_openflow_instructions()

ofpacts_pull_openflow_instructions() should fill 'ofpacts' with a list
of OpenFlow actions and each action (including the last one) should be
padded to OFP_ACTION_ALIGN(8) bytes.

In most of the cases this is taken care of (e.g. by ofpacts_decode), but
for the Goto-Table instruction (and Clear-Actions, based on a quick code
inspection), this wasn't the case.

This caused the copy operation in recirc_unroll_actions() to read two
extra bytes after an allocated area (not a big deal, but enough to
displease the AddressSanitizer).

Signed-off-by: William Tu <u9012063 at gmail.com>
Signed-off-by: Daniele Di Proietto <diproiettod at vmware.com>
Co-authored-by: Daniele Di Proietto <diproiettod at vmware.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>




More information about the git mailing list