[ovs-git] [openvswitch/ovs] a96882: ofp-parse: Correctly update bucket lists if they a...

GitHub noreply at github.com
Fri Feb 13 22:47:19 UTC 2015


  Branch: refs/heads/branch-2.1
  Home:   https://github.com/openvswitch/ovs
  Commit: a9688201c0069d4a40e93a83c74a456884284e33
      https://github.com/openvswitch/ovs/commit/a9688201c0069d4a40e93a83c74a456884284e33
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-02-13 (Fri, 13 Feb 2015)

  Changed paths:
    M lib/list.c
    M lib/list.h
    M lib/ofp-parse.c

  Log Message:
  -----------
  ofp-parse: Correctly update bucket lists if they are empty.

Previously, list_moved() only worked with non-empty lists, but this was a
caveat that was really easy to miss.  parse_ofp_group_mod_file() had a bug
because it didn't honor that restriction.  This commit fixes the problem,
by modifying the list_moved() interface to be harder to use incorrectly
and then updating the callers.

Reported-by: Simon Horman <simon.horman at netronome.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Thomas Graf <tgraf at noironetworks.com>




More information about the git mailing list