[ovs-git] [openvswitch/ovs] 93e83e: CONTRIBUTING.md: Strengthen testing recommendataio...

GitHub noreply at github.com
Sun Feb 15 16:39:35 UTC 2015

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 93e83e8b8a2735ed1c515e9dddc1d45927ebf754
  Author: Mark Kavanagh <mark.b.kavanagh at intel.com>
  Date:   2015-02-15 (Sun, 15 Feb 2015)

  Changed paths:

  Log Message:
  CONTRIBUTING.md: Strengthen testing recommendataions.

Patches that modify existing code can break expected behaviour.
Flag this by testing the patch with 'make check' prior to submission.

Furthermore, it is not sufficient to only test patches that add files
using 'make distcheck'; the compile flags for this target could change
the definition of some functions (ovs_assert, for example), altering
the outcome of some unit tests. Rather, it is preferable to use a
combination of 'make distcheck' with 'make check' to cover all bases.

Signed-off-by: Mark Kavanagh <mark.b.kavanagh at intel.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>

More information about the git mailing list