[ovs-git] [openvswitch/ovs] 2a638b: test-hash: Remove the check_word_hash() for hash_b...

GitHub noreply at github.com
Fri Feb 27 17:05:06 UTC 2015

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 2a638b8d22be66bb631b2273a72cd4c8451de065
  Author: Alex Wang <alexw at nicira.com>
  Date:   2015-02-27 (Fri, 27 Feb 2015)

  Changed paths:
    M lib/hash.h
    M tests/test-hash.c

  Log Message:
  test-hash: Remove the check_word_hash() for hash_bytes128_cb.

The original test fails on big-endian system due to the hash function
performing not as well when input is uint32_t.  In reality, users should
only use hash_bytes128() to hash words larger than 128 bits (e.g. struct
flow).  Besides, we do check the 1-bit set case for 16 128-bit words in
following test case.  Therefore, the cleanest way to fix the failure
in big-endian system seems to be just removing the check_word_hash()
test for hash_bytes128_cb.

Signed-off-by: Alex Wang <alexw at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>

More information about the git mailing list