[ovs-git] [openvswitch/ovs] 4c6b0a: pktbuf: Always initialize '*bufferp' even when 'pb...

GitHub noreply at github.com
Mon Jan 19 18:09:27 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 4c6b0ad74fe4adc993949807d9d5d45124ff6f50
      https://github.com/openvswitch/ovs/commit/4c6b0ad74fe4adc993949807d9d5d45124ff6f50
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-01-19 (Mon, 19 Jan 2015)

  Changed paths:
    M ofproto/pktbuf.c

  Log Message:
  -----------
  pktbuf: Always initialize '*bufferp' even when 'pb == NULL'.

Otherwise if a service connection (which does not have buffers) attempts
to use buffers, '*bufferp' will be uninitialized, which can cause a
segfault in the caller.

Found using OFtest configured to use service (active rather than passive)
connections.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Thomas Graf <tgraf at noironetworks.com>


  Commit: f33368ee6d64c8c264d75c4486b5f9802d327c62
      https://github.com/openvswitch/ovs/commit/f33368ee6d64c8c264d75c4486b5f9802d327c62
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-01-19 (Mon, 19 Jan 2015)

  Changed paths:
    M lib/rconn.c
    M lib/rconn.h

  Log Message:
  -----------
  rconn: Remove dead code and data.

These functions had no callers, so remove them and the data maintained
just to implement them.

Found by inspection.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Thomas Graf <tgraf at noironetworks.com>


Compare: https://github.com/openvswitch/ovs/compare/cc23805ccf03...f33368ee6d64


More information about the git mailing list