[ovs-git] [openvswitch/ovs] ebdabd: autotest: Fix kernel module unit test teardown

GitHub noreply at github.com
Thu Jan 29 04:50:50 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: ebdabd05e9465dd6e50adedb4a0bcb5678e563de
      https://github.com/openvswitch/ovs/commit/ebdabd05e9465dd6e50adedb4a0bcb5678e563de
  Author: Christoph Jaeger <cj at linux.com>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M AUTHORS
    M tests/kmod-macros.at

  Log Message:
  -----------
  autotest: Fix kernel module unit test teardown

Due to a misnaming, the macro calls

  OVS_SWITCHD_STOP([$1])
  AT_CHECK([modprobe -r openvswitch])

in OVS_KMOD_VSWITCHD_STOP make up a syntactically correct function definition
(OVS_SWITCHD_STOP does not exist, and therefore the call does not expand):

  OVS_SWITCHD_STOP()
  { set +x
  $as_echo "$at_srcdir/kmod-traffic.at:15: modprobe -r openvswitch"
  ...
  $at_traceon; }

Consequently, neither of the calls has the intended effect, i.e., stopping
ovs-vswitchd and ovsdb-server, checking their log files, and unloading the
datapath kernel module. Fix the misnaming, so all calls expand properly.

Fixes: 69c2bdfef9 ("autotest: add autotest framework for adding kernel module unit tests")
Signed-off-by: Christoph Jaeger <cj at linux.com>
Signed-off-by: Andy Zhou <azhou at nicira.com>

Author: add Christoph Jaeger




More information about the git mailing list