[ovs-git] [openvswitch/ovs] 33b2ad: datapath: allocate nr_node_ids flow_stats instead ...

GitHub noreply at github.com
Wed Jul 22 21:08:13 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 33b2ad88ef3d02b79517d0f4e387654fce0da41d
      https://github.com/openvswitch/ovs/commit/33b2ad88ef3d02b79517d0f4e387654fce0da41d
  Author: Chris J Arges <chris.j.arges at canonical.com>
  Date:   2015-07-22 (Wed, 22 Jul 2015)

  Changed paths:
    M datapath/flow_table.c

  Log Message:
  -----------
  datapath: allocate nr_node_ids flow_stats instead of num_possible_nodes

Some architectures like POWER can have a NUMA node_possible_map that
contains sparse entries. This causes memory corruption with openvswitch
since it allocates flow_cache with a multiple of num_possible_nodes()
and
assumes the node variable returned by for_each_node will index into
flow->stats[node].

Use nr_node_ids to allocate a maximal sparse array instead of
num_possible_nodes().

The crash was noticed after 3af229f2 was applied as it changed the
node_possible_map to match node_online_map on boot.
Fixes: 3af229f2071f5b5cb31664be6109561fbe19c861

Signed-off-by: Chris J Arges <chris.j.arges at canonical.com>
Signed-off-by: Pravin B Shelar <pshelar at nicira.com>




More information about the git mailing list