[ovs-git] [openvswitch/ovs] aa379b: ofproto: Ignore generation ID for role change to "...

[GitHub]

  Branch: refs/heads/branch-2.4
  Home:   https://github.com/openvswitch/ovs
  Commit: aa379b44afa72232e5d7176d5e95b2950bc5dee5
      https://github.com/openvswitch/ovs/commit/aa379b44afa72232e5d7176d5e95b2950bc5dee5
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-07-29 (Wed, 29 Jul 2015)

  Changed paths:
    M ofproto/ofproto.c

  Log Message:
  -----------
  ofproto: Ignore generation ID for role change to "equal".

The OpenFlow specification says that only role changes to slave or master
check the generation ID, so this is a bug fix.

OpenFlow 1.2 section A.3.9 phrases the requirement this way:

    Additionally, if the role value in the message is OFPCR_ROLE_MASTER
    or OFPCR_ROLE_SLAVE, the switch must validate generation_id to check
    for stale messages.

Found by OFTest.

Signed-off-by: Ben Pfaff <blp at nicira.com>