[ovs-git] [openvswitch/ovs] deab5e: ovn-controller: Factor encapsulation code out of c...

GitHub noreply at github.com
Thu Jul 30 17:37:17 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: deab5e6703fe911b464df8eec8be91207b67bec0
      https://github.com/openvswitch/ovs/commit/deab5e6703fe911b464df8eec8be91207b67bec0
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M ovn/controller/automake.mk
    M ovn/controller/chassis.c
    M ovn/controller/chassis.h
    A ovn/controller/encaps.c
    A ovn/controller/encaps.h
    M ovn/controller/ovn-controller.c

  Log Message:
  -----------
  ovn-controller: Factor encapsulation code out of chassis code.

These two pieces of code have different requirements and hardly anything in
common, and I found it easier to understand and reasonably modify the
overall structure of the program when they were separated.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Justin Pettit <jpettit at nicira.com>


  Commit: 4acc496ecd359088cdf1ce4d549c65828f928e72
      https://github.com/openvswitch/ovs/commit/4acc496ecd359088cdf1ce4d549c65828f928e72
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M ovn/controller/binding.c
    M ovn/controller/binding.h
    M ovn/controller/chassis.c
    M ovn/controller/chassis.h
    M ovn/controller/encaps.c
    M ovn/controller/encaps.h
    M ovn/controller/ovn-controller.c
    M ovn/controller/ovn-controller.h
    M ovn/controller/physical.c
    M ovn/controller/physical.h

  Log Message:
  -----------
  ovn-controller: Pass 'chassis_id' explicitly to functions that need it.

I found it otherwise difficult to see what code depended on this.  When
later commits make it possible for ovn-controller to handle changes in
chassis ID, this will become important (the code should determine the
current chassis ID before trying to use it).

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Justin Pettit <jpettit at nicira.com>


  Commit: 37c7a694379227a23a5073d099d2b74b6a6a3567
      https://github.com/openvswitch/ovs/commit/37c7a694379227a23a5073d099d2b74b6a6a3567
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M ovn/controller/binding.c
    M ovn/controller/encaps.c
    M ovn/controller/ofctrl.c
    M ovn/controller/ovn-controller.c

  Log Message:
  -----------
  ovn-controller: Tolerate missing integration bridge.

Until now, if the integration bridge was missing, ovn-controller exited.
This commit makes it wait until the integration bridge is created.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Justin Pettit <jpettit at nicira.com>


  Commit: 30a4256fd082e65fb3c45d44f107bbdad2230cae
      https://github.com/openvswitch/ovs/commit/30a4256fd082e65fb3c45d44f107bbdad2230cae
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M ovn/controller/binding.c
    M ovn/controller/chassis.c
    M ovn/controller/ovn-controller.c

  Log Message:
  -----------
  ovn-controller: Tolerate missing 'chassis_id'.

Until now, if the chassis id was missing, ovn-controller exited.  This
commit makes ovn-controller wait for it to return.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Justin Pettit <jpettit at nicira.com>


  Commit: 4a5a9e0640fb9e0d11067194bdb9f8e5300a8668
      https://github.com/openvswitch/ovs/commit/4a5a9e0640fb9e0d11067194bdb9f8e5300a8668
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M ovn/controller/binding.c
    M ovn/controller/binding.h
    M ovn/controller/chassis.c
    M ovn/controller/chassis.h
    M ovn/controller/encaps.c
    M ovn/controller/encaps.h
    M ovn/controller/ovn-controller.c
    M ovn/controller/physical.c
    M ovn/controller/physical.h

  Log Message:
  -----------
  ovn-controller: Rename init functions that just register IDL columns.

The generic *_init() names for these functions made it sounds like they
do something more than just register IDL columns, even though that's all
they do.  Also, the controller_ctx that was passed into each of them was
only used to get the IDL handle.  This commit renames them and changes
their parameter type to simplify and make all of this clearer.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Justin Pettit <jpettit at nicira.com>


  Commit: 9e8fa2b6c7a77bf31e672e05e10b4f862b57f8b8
      https://github.com/openvswitch/ovs/commit/9e8fa2b6c7a77bf31e672e05e10b4f862b57f8b8
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-07-30 (Thu, 30 Jul 2015)

  Changed paths:
    M ovn/controller/ovn-controller.c

  Log Message:
  -----------
  ovn-controller: Honor external-ids:ovn-bridge changing.

Until now, if external-ids:ovn-bridge changed, ovn-controller ignored
the change.  With this commit, ovn-controller uses the new bridge.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Justin Pettit <jpettit at nicira.com>


Compare: https://github.com/openvswitch/ovs/compare/64e8c446ae14...9e8fa2b6c7a7


More information about the git mailing list