[ovs-git] [openvswitch/ovs] 40e7cf: configure: Stop avoiding -Wformat-zero-length.

GitHub noreply at github.com
Wed Jun 10 16:19:42 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 40e7cf5607052d3b4fa09fd433fa630352c115b6
      https://github.com/openvswitch/ovs/commit/40e7cf5607052d3b4fa09fd433fa630352c115b6
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-06-10 (Wed, 10 Jun 2015)

  Changed paths:
    M configure.ac
    M debian/rules
    M lib/ovs-thread.c
    M lib/util.c
    M lib/util.h
    M tests/test-util.c

  Log Message:
  -----------
  configure: Stop avoiding -Wformat-zero-length.

Debian likes to enable -Wformat-zero-length, even over our code trying to
disable it.  It isn't too hard to make our code warning-free against this
option, so this commit both stops disabling it and fixes the warnings.

The first fix is to change set_subprogram_name() to take a plain string
instead of a format string, and to adjust its few callers.  This fixes one
warning since one of those callers passed in an empty string.

The second fix is to remove a test for ovs_scan() against an empty string.
I couldn't find a way to avoid a warning for this test, and it isn't too
valuable in any case.

This allows us to drop filtering for -Wformat from the Debian rules file,
so this commit removes it.

Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: 40c9675a1e88804fcef9658ddacdf80dd82a1763
      https://github.com/openvswitch/ovs/commit/40c9675a1e88804fcef9658ddacdf80dd82a1763
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-06-10 (Wed, 10 Jun 2015)

  Changed paths:
    M debian/rules

  Log Message:
  -----------
  debian: Remove obsolete manual setting of CFLAGS and warnings from rules.

Setting CFLAGS by hand before invoking dpkg-buildflags is ineffective,
because dpkg-buildflags overrides it.

Reported-by: Andrey Korolyov <andrey at xdel.ru>
Signed-off-by: Ben Pfaff <blp at nicira.com>


Compare: https://github.com/openvswitch/ovs/compare/bdd7ecf5bfc4...40c9675a1e88


More information about the git mailing list