[ovs-git] [openvswitch/ovs] cbc083: netdev-vport: Mark netdev_vport_get_dpif_port() as...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: cbc083e330186a23c17a1bea284f39dfe9ffb2ad
      https://github.com/openvswitch/ovs/commit/cbc083e330186a23c17a1bea284f39dfe9ffb2ad
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-06-11 (Thu, 11 Jun 2015)

  Changed paths:
    M lib/netdev-vport.h

  Log Message:
  -----------
  netdev-vport: Mark netdev_vport_get_dpif_port() as OVS_WARN_UNUSED_RESULT.

Ignoring the result of this function means that the caller is quite likely
blindly using the character array passed in, instead of the return value,
which leads to latent bugs.

This would have prevented one of the bugs fixed by commit "tunneling: Fix a
tunnel name display bug".

CC: Andy Zhou <azhou at nicira.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Andy Zhou <azhou at nicira.com>