[ovs-git] [openvswitch/ovs] 0b623a: datapath-windows: use correct dst port during Vxla...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 0b623ad5a8b8ab2a8b7441bd43579eb52bdc672f
      https://github.com/openvswitch/ovs/commit/0b623ad5a8b8ab2a8b7441bd43579eb52bdc672f
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2015-06-19 (Fri, 19 Jun 2015)

  Changed paths:
    M datapath-windows/ovsext/Actions.c
    M datapath-windows/ovsext/Stt.c
    M datapath-windows/ovsext/Vxlan.c
    M datapath-windows/ovsext/Vxlan.h

  Log Message:
  -----------
  datapath-windows: use correct dst port during Vxlan Tx

A previous commit used the wrong DST port in the UDP header during Vxlan
Tx which caused Vxlan tunneling to break. Fixing it here..

Also included is a cosmetic fix in OvsDetectTunnelRxPkt() where we were
using htons() instead of ntohs(). Doesn't make a difference in practice
though.

One more change is, OvsIpHlprCbVxlan() has been nuked since it is not
used. Not sure if it is worth being resurrected.

Testing done: Ping across Vxlan tunnel and Stt tunnel.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Reported-by: Eitan Eliahu <eliahue at vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>


  Commit: 18b19ad911702dcaa861368f1bb059ed5e84ae31
      https://github.com/openvswitch/ovs/commit/18b19ad911702dcaa861368f1bb059ed5e84ae31
  Author: Sorin Vinturis <svinturis at cloudbasesolutions.com>
  Date:   2015-06-19 (Fri, 19 Jun 2015)

  Changed paths:
    M datapath-windows/ovsext/Switch.c

  Log Message:
  -----------
  datapath-windows: Initialize reference count when enabling extension

When the extension is initialized the global reference count, used for
preventing early deallocation of the switch extension, is set to 1.
Enabling and then disabling the extension leaves the latter reference
count to zero. Because of this the switch context fails to be acquired,
i.e OvsAcquireSwitchContext returns zero, and that affects driver's
communication to the userspace.

The solution is to initialize the reference count each time the extension
is enabled.

Signed-off-by: Sorin Vinturis <svinturis at cloudbasesolutions.com>
Reported-by: Nithin Raju <nithin at vmware.com>
Reported-at: https://github.com/openvswitch/ovs-issues/issues/86
Acked-by: Nithin Raju <nithin at vmware.com>
Signed-off-by: Gurucharan Shetty <gshetty at nicira.com>


Compare: https://github.com/openvswitch/ovs/compare/2d34dbd9e170...18b19ad91170