[ovs-git] [openvswitch/ovs] 961440: python: Fix attempt to use a bool as a function.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 9614403da9e5e22b13f22125a15c63287532481c
      https://github.com/openvswitch/ovs/commit/9614403da9e5e22b13f22125a15c63287532481c
  Author: Sumit Garg <sumit at extremenetworks.com>
  Date:   2015-06-25 (Thu, 25 Jun 2015)

  Changed paths:
    M python/ovs/db/idl.py

  Log Message:
  -----------
  python: Fix attempt to use a bool as a function.

A bool (has_lock) was being accessed as a function call leading to a
runtime exception.

Signed-off-by: Sumit Garg <sumit at extremenetworks.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: 7a5568826f49b41e504903e57df3fd6d9f801dc4
      https://github.com/openvswitch/ovs/commit/7a5568826f49b41e504903e57df3fd6d9f801dc4
  Author: Sumit Garg <sumit at extremenetworks.com>
  Date:   2015-06-25 (Thu, 25 Jun 2015)

  Changed paths:
    M python/ovs/db/idl.py

  Log Message:
  -----------
  python: Fix writing to non-"alert" column for newly inserted row.

When 'alert' was turned off on a column, the code was erroring out when
value for that column was being set in a newly inserted row. This is
because the row._data was None at this time.

It seems that new rows are not initialized to defaults and that's why the
NULL error happens.  IMO a newly inserted row should automatically get
intialized to default values.  This new behavior can be implemented as a
separate improvement sometime in the future.

For now, I don't see an issue with adding the additional check. This new
check can continue as-is even after the new behavior is implemented.

Signed-off-by: Sumit Garg <sumit at extremenetworks.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


  Commit: f5cd74291d02f3723e175048db87b2914cd99e34
      https://github.com/openvswitch/ovs/commit/f5cd74291d02f3723e175048db87b2914cd99e34
  Author: Sumit Garg <sumit at extremenetworks.com>
  Date:   2015-06-25 (Thu, 25 Jun 2015)

  Changed paths:
    M python/ovs/jsonrpc.py

  Log Message:
  -----------
  python: Fix issue with probes for JSONRPC connections

When opening a JSONRPC connection, the health probes
are incorrectly getting turned off for connections
that need probes.

In other words, when stream_or_pstream_needs_probes()
return non-zero, the probes are gettting disabled as
the probe interval is getting set to zero. This leads
to incorrect behavior such that probes are:

  - not getting turned off for unix: connections
  - getting turned off for tcp:/ssl: connections

The changes in this commit fix this issue.

Signed-off-by: Sumit Garg <sumit at extremenetworks.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>


Compare: https://github.com/openvswitch/ovs/compare/3e2e75881358...f5cd74291d02