[ovs-git] [openvswitch/ovs] eaac0f: tunneling: Don't match on source IP address for na...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: eaac0f22b95c34e99a4c14910359148726f9725c
      https://github.com/openvswitch/ovs/commit/eaac0f22b95c34e99a4c14910359148726f9725c
  Author: Jesse Gross <jesse at nicira.com>
  Date:   2015-06-25 (Thu, 25 Jun 2015)

  Changed paths:
    M lib/tnl-ports.c
    M lib/tnl-ports.h
    M ofproto/tunnel.c
    M tests/tunnel-push-pop.at

  Log Message:
  -----------
  tunneling: Don't match on source IP address for native tunnels.

When doing native tunneling, we look at packets destined to the
local port to see if they match tunnel protocols that we should
intercept. The criteria are IP protocol, destination UDP port, etc.

However, we also look at the source IP address of the packets. This
should be a function of the port-based tunnel layer and not the
tunnel receive code itself. For comparison, the kernel tunnel code
has no idea about the IP addresses of its link partners. If port
based tunnel is desired, it can be handled using the normal port
tunnel layer, regardless of whether the packets originally came
from userspace or the kernel.

For port based tunneling, this bug has no effect - the check is
simply redundant. However, it breaks flow-based native tunnels
because the remote IP address is not known at port creation time.

CC: Pravin Shelar <pshelar at nicira.com>
Reported-by: David Griswold <David.Griswold at overturenetworks.com>
Tested-by: David Griswold <David.Griswold at overturenetworks.com>
Signed-off-by: Jesse Gross <jesse at nicira.com>