[ovs-git] [openvswitch/ovs] daab0a: ofproto: Fix use-after-free in bridge destruction ...

GitHub noreply at github.com
Fri Jun 26 15:45:45 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: daab0ae6bb558411f24cee6a7bb32599a5f9e363
      https://github.com/openvswitch/ovs/commit/daab0ae6bb558411f24cee6a7bb32599a5f9e363
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-06-26 (Fri, 26 Jun 2015)

  Changed paths:
    M ofproto/ofproto-dpif.c
    M ofproto/ofproto-provider.h
    M ofproto/ofproto.c
    M tests/ofproto.at

  Log Message:
  -----------
  ofproto: Fix use-after-free in bridge destruction with groups.

Groups were not destroyed until after lots of other important bridge
data had been destroyed, including the connection manager.  There was an
indirect dependency on the connection manager for bridge destruction
because destroying a group also destroys all of the flows that reference
the group, which in turn causes the ofmonitor to be invoked to report that
the flows had been destroyed.  This commit fixes the problem by destroying
groups earlier.

The problem can be observed by reverting the code changes in this commit
then running "make check-valgrind" with the test that this commit
introduces.

Reported-by: Simon Horman <simon.horman at netronome.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>
Reviewed-by: Simon Horman <simon.horman at netronome.com>




More information about the git mailing list