[ovs-git] [openvswitch/ovs] be53a5: auto-attach: Initial support for Auto-Attach stand...

Wed Mar 4 00:39:26 UTC 2015

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: be53a5c447c3ed77ef2d4e1e09ea63de576b90e8
      https://github.com/openvswitch/ovs/commit/be53a5c447c3ed77ef2d4e1e09ea63de576b90e8
  Author: Dennis Flynn <drflynn at avaya.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M NOTICE
    M debian/copyright.in
    M lib/automake.mk
    A lib/lldp/aa-structs.h
    A lib/lldp/lldp-const.h
    A lib/lldp/lldp-tlv.h
    A lib/lldp/lldp.c
    A lib/lldp/lldpd-structs.c
    A lib/lldp/lldpd-structs.h
    A lib/lldp/lldpd.c
    A lib/lldp/lldpd.h
    A lib/ovs-lldp.c
    A lib/ovs-lldp.h

  Log Message:
  -----------
  auto-attach: Initial support for Auto-Attach standard

This commit provides the initial delivery of support for the Auto-Attach
standard to Open vSwitch. This standard describes a compact method of using
IEEE 802.1AB Link Layer Discovery Protocol (LLDP) with a IEEE 802.1aq Shortest
Path Bridging (SPB) network to automatically attach network devices not
supporting IEEE 802.1ah to individual services in a SPB network. Specifically
this commit adds base LLDP support to OVS along with the LLDP extension
required to support Auto-Attach.

The base LLDP code within this commit is adapted from the open source LLDPD
project headed by Vincent Bernat. This base code is augmented with OVS specific
logic which integrates LLDP into OVS and which extends LLDP to support
Auto-Attach. The required build system changes are provided to include this new
Auto-Attach feature.

This is the first of a series of commits. Subsequent commits will be provided
to complete the task of adding Auto-Attach to OVS.

Signed-off-by: Ludovic Beliveau <ludovic.beliveau at windriver.com>
Signed-off-by: Dennis Flynn <drflynn at avaya.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 0477baa93b44dc9221e61eddf92545c5d7c477d7
      https://github.com/openvswitch/ovs/commit/0477baa93b44dc9221e61eddf92545c5d7c477d7
  Author: Dennis Flynn <drflynn at avaya.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/bfd.c
    M lib/bfd.h
    M lib/cfm.c
    M lib/cfm.h
    M lib/lldp/lldp.c
    M lib/lldp/lldpd.c
    M lib/lldp/lldpd.h
    M lib/odp-util.h
    M lib/ovs-lldp.c
    M lib/ovs-lldp.h
    M ofproto/ofproto-dpif-monitor.c
    M ofproto/ofproto-dpif-monitor.h
    M ofproto/ofproto-dpif-xlate.c
    M ofproto/ofproto-dpif-xlate.h
    M ofproto/ofproto-dpif.c
    M ofproto/ofproto-provider.h
    M ofproto/ofproto.c
    M ofproto/ofproto.h

  Log Message:
  -----------
  auto-attach: Add auto-attach support to ofproto layer

Signed-off-by: Ludovic Beliveau <ludovic.beliveau at windriver.com>
Signed-off-by: Dennis Flynn <drflynn at avaya.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 99eef98b53b1099b9c698b9d042c599bbc1648b2
      https://github.com/openvswitch/ovs/commit/99eef98b53b1099b9c698b9d042c599bbc1648b2
  Author: Dennis Flynn <drflynn at avaya.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M NEWS
    A tests/auto-attach.at
    M tests/automake.mk
    M tests/ovs-vsctl.at
    A tests/test-aa.c
    M tests/testsuite.at
    M utilities/ovs-vsctl.8.in
    M utilities/ovs-vsctl.c
    M vswitchd/bridge.c
    M vswitchd/vswitch.ovsschema
    M vswitchd/vswitch.xml

  Log Message:
  -----------
  auto-attach: Add auto-attach support to bridge layer and command set

This is the final commit in the series of commits that deliver initial support
for Auto-Attach. Specifically this commit delivers auto-attach support to the
OVS bridge layer as well as the new auto-attach commands. The OVSDB schema is
modified to define the new auto-attach entries. The man pages, unit tests, and
news and license notice files are also updated. A unit test is provided to
validate the construction of auto-attach packets.

Signed-off-by: Ludovic Beliveau <ludovic.beliveau at windriver.com>
Signed-off-by: Dennis Flynn <drflynn at avaya.com>
Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 501b80538d7ab9a46a53a746ab109c04f8a6b9ab
      https://github.com/openvswitch/ovs/commit/501b80538d7ab9a46a53a746ab109c04f8a6b9ab
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M utilities/ovs-vsctl.c

  Log Message:
  -----------
  ovs-vsctl: Fix misused casts.

Without the casts, the argument types match the format specifiers.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 22736f59c1c3d35662be0369321041c06747f7b9
      https://github.com/openvswitch/ovs/commit/22736f59c1c3d35662be0369321041c06747f7b9
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldp.c
    M tests/test-aa.c

  Log Message:
  -----------
  lldp: Get rid of POKE macros in favor of inline functions.

The POKE macros previously used here don't match the style usually used in
OVS and they require the user to know exactly how many bytes to reserve.
This commit replaces them by easier-to-use inline functions that take
advantage of the ofpbuf interface.

Also removes a few PEEK macros that weren't used anywhere.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: cc84196628a359b6d0ddc87b5294c39ad700fa01
      https://github.com/openvswitch/ovs/commit/cc84196628a359b6d0ddc87b5294c39ad700fa01
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldp.c
    M lib/lldp/lldpd-structs.h
    M lib/lldp/lldpd.c
    M lib/ovs-lldp.c

  Log Message:
  -----------
  lldp: Use x*alloc() functions instead of writing them out in-place.

Also use flexible array member instead of array of length 1 in
struct lldpd_frame.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 4eb6eec6f8d71e1de2fcf8db094069f41edca471
      https://github.com/openvswitch/ovs/commit/4eb6eec6f8d71e1de2fcf8db094069f41edca471
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/ovs-lldp.c

  Log Message:
  -----------
  ovs-lldp: Use correct printf specifiers.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: d9f3b69e7c20b7ff92b769fd9839ec8701f839d8
      https://github.com/openvswitch/ovs/commit/d9f3b69e7c20b7ff92b769fd9839ec8701f839d8
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldpd-structs.c
    M lib/lldp/lldpd.c

  Log Message:
  -----------
  lldp: Use OVS time functions.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 02d593b1940b6c6ea6f4452992f174a928b274d3
      https://github.com/openvswitch/ovs/commit/02d593b1940b6c6ea6f4452992f174a928b274d3
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldp.c
    M lib/lldp/lldpd-structs.c
    M lib/lldp/lldpd-structs.h
    M lib/lldp/lldpd.c

  Log Message:
  -----------
  lldp: Use "bool" for boolean variables.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 8a42c2d6752eaa61ff130d85fb023d5a7b81e968
      https://github.com/openvswitch/ovs/commit/8a42c2d6752eaa61ff130d85fb023d5a7b81e968
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldp.c
    M lib/lldp/lldpd.c

  Log Message:
  -----------
  lldp: Declare "bool" variables as type "bool".

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: e8fa10d7546a46173d5607c4545b8bede7cbb377
      https://github.com/openvswitch/ovs/commit/e8fa10d7546a46173d5607c4545b8bede7cbb377
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldpd-structs.c

  Log Message:
  -----------
  lldpd-structs: Fix spelling error in message.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 24885e3232f53d81856ea3c6166ff7564b27af9d
      https://github.com/openvswitch/ovs/commit/24885e3232f53d81856ea3c6166ff7564b27af9d
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M tests/test-aa.c

  Log Message:
  -----------
  test-aa: Make variables local to this file static.

Found by sparse.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 02c842eb74e9d966dd613aed149490e28c06ec3b
      https://github.com/openvswitch/ovs/commit/02c842eb74e9d966dd613aed149490e28c06ec3b
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/aa-structs.h
    M lib/lldp/lldp.c
    M lib/ovs-lldp.c
    M tests/test-aa.c

  Log Message:
  -----------
  lldp: Change representation of ISID to uint32_t.

It's a lot more straightforward to deal with integer values as integers
instead of arrays of bytes.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 854560f8dc6f4929d7c850f5ac3f94c61a597920
      https://github.com/openvswitch/ovs/commit/854560f8dc6f4929d7c850f5ac3f94c61a597920
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldp.c
    M lib/lldp/lldpd-structs.h
    M lib/ovs-lldp.c
    M tests/test-aa.c

  Log Message:
  -----------
  lldp-structs: Fix use of list of lldpd_aa_isid_vlan_maps_tlv.

A list of some type should have type "struct ovs_list", not some other
type that encapsulates it.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 32590179d45f7096d488b8de1b6eb97d2b3cea0a
      https://github.com/openvswitch/ovs/commit/32590179d45f7096d488b8de1b6eb97d2b3cea0a
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldp.c
    M lib/lldp/lldpd-structs.c
    M lib/lldp/lldpd-structs.h
    M lib/lldp/lldpd.c
    M lib/ovs-lldp.c

  Log Message:
  -----------
  lldp-structs: Fix use of list of struct lldpd_mgmt.

A list of some type should have type "struct ovs_list", not some other
type that encapsulates it.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 135706b39307f84fb0c9a5d1ffeebb9f7f556b9e
      https://github.com/openvswitch/ovs/commit/135706b39307f84fb0c9a5d1ffeebb9f7f556b9e
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldpd-structs.c
    M lib/lldp/lldpd-structs.h
    M lib/lldp/lldpd.c
    M lib/ovs-lldp.c

  Log Message:
  -----------
  lldp-structs: Fix use of list of struct lldpd_port.

A list of some type should have type "struct ovs_list", not some other
type that encapsulates it.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 72c642e5ab553fd11eb69208b3949065f689f17d
      https://github.com/openvswitch/ovs/commit/72c642e5ab553fd11eb69208b3949065f689f17d
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/ovs-lldp.c
    M lib/ovs-lldp.h
    M vswitchd/bridge.c

  Log Message:
  -----------
  ovs-lldp: Use better types for ISID and VLANs.

An ISID is 24 bits, so it fits in a uint32_t.  A VLAN is 12 bits, so it
fits in a uint16_t.  Use these types consistently, instead of int64_t.

This removes a check in aa_mapping_unregister() that seems a little
mysterious to me: it previously checked for ISID and VLAN values >= 0.  I
don't see a way that they could be < 0 in this situation though.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 1acaf4ac8fc9a6ba1af973ded44bfd7da4de0acd
      https://github.com/openvswitch/ovs/commit/1acaf4ac8fc9a6ba1af973ded44bfd7da4de0acd
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldp.c
    M lib/lldp/lldpd-structs.h
    M lib/ovs-lldp.c
    M tests/test-aa.c

  Log Message:
  -----------
  lldpd-structs: Fix type of c_id member.

This member is typically an Ethernet address so the appropriate type is
uint8_t, not char.  This eliminates a couple of casts.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: f856318e14ccee4617b0d9e6a0259558915fd59c
      https://github.com/openvswitch/ovs/commit/f856318e14ccee4617b0d9e6a0259558915fd59c
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldp.c
    M lib/lldp/lldpd-structs.h
    M lib/ovs-lldp.c

  Log Message:
  -----------
  lldp: Miscellaneous coding style fixes.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 224f05de492f478b66e73df48525d449b1160acf
      https://github.com/openvswitch/ovs/commit/224f05de492f478b66e73df48525d449b1160acf
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/ovs-lldp.c

  Log Message:
  -----------
  ovs-lldp: Remove unneeded NULL checks on free().

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 24738b7e993e9bc5cccc73c7b95bb3e924cb4af7
      https://github.com/openvswitch/ovs/commit/24738b7e993e9bc5cccc73c7b95bb3e924cb4af7
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldpd.c

  Log Message:
  -----------
  lldpd: Remove obsolete comment.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 937f71bf6c51d3dcab7d892601a22f5b251ab5f4
      https://github.com/openvswitch/ovs/commit/937f71bf6c51d3dcab7d892601a22f5b251ab5f4
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldpd.c

  Log Message:
  -----------
  lldpd: Use CONTAINER_OF instead of cast, for safety.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 809fd54df3ecb90d8e0ea84a614ba3432a97de2b
      https://github.com/openvswitch/ovs/commit/809fd54df3ecb90d8e0ea84a614ba3432a97de2b
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldpd.h

  Log Message:
  -----------
  lldpd: Remove unused ALIGNED_CAST macro.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: a268e134b6088e8b9d255b19ae1cbb219378c0fe
      https://github.com/openvswitch/ovs/commit/a268e134b6088e8b9d255b19ae1cbb219378c0fe
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldpd.c

  Log Message:
  -----------
  lldpd: Fix return value convention for "send" function.

errno values are positive values, so it's not reasonable to use E2BIG as
an error return with positive values also indicating packet lengths.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: f94d6e78047294e5b88364636cb3e50ee58cc283
      https://github.com/openvswitch/ovs/commit/f94d6e78047294e5b88364636cb3e50ee58cc283
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldp.c
    M lib/lldp/lldpd.c

  Log Message:
  -----------
  lldp: Remove excessive parentheses.

The OVS style is to usually avoid parentheses in cases like these where
they just make expressions harder to read.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 6db3f8b065dd528469884ea93eae7f120602a077
      https://github.com/openvswitch/ovs/commit/6db3f8b065dd528469884ea93eae7f120602a077
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldp.c

  Log Message:
  -----------
  lldp: Use ETH_ADDR_FMT.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 806cc1ebe558960b0d1392e64459a7bc59c18e84
      https://github.com/openvswitch/ovs/commit/806cc1ebe558960b0d1392e64459a7bc59c18e84
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldpd.h

  Log Message:
  -----------
  lldpd: Remove unused members from struct lldpd.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 3622191996edd0daa5c4ac3f4c5ffaafd59aa8e8
      https://github.com/openvswitch/ovs/commit/3622191996edd0daa5c4ac3f4c5ffaafd59aa8e8
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldpd-structs.h

  Log Message:
  -----------
  lldpd-structs: Declare Boolean member as one bit, not two.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: e87a8e67fa75483f9de804370a36ebc01f85ddc9
      https://github.com/openvswitch/ovs/commit/e87a8e67fa75483f9de804370a36ebc01f85ddc9
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldpd.c
    M lib/lldp/lldpd.h
    M lib/ovs-lldp.c

  Log Message:
  -----------
  lldpd: Fix use of list of struct lldpd_chassis.

A list of some type should have type "struct ovs_list", not some other
type that encapsulates it.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 2cbb2d9011e7301c6f35fee1ed3f998e350119b4
      https://github.com/openvswitch/ovs/commit/2cbb2d9011e7301c6f35fee1ed3f998e350119b4
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldpd.c
    M lib/lldp/lldpd.h
    M lib/ovs-lldp.c
    M tests/test-aa.c

  Log Message:
  -----------
  lldpd: Fix use of list of struct lldpd_hardware.

A list of some type should have type "struct ovs_list", not some other
type that encapsulates it.

This ovs_list is a bit puzzling in itself, because it appears to always
have exactly one element.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: 88f07b589235bec803d9b2b7e2c1a4937bff174c
      https://github.com/openvswitch/ovs/commit/88f07b589235bec803d9b2b7e2c1a4937bff174c
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldpd-structs.h
    M lib/lldp/lldpd.h
    M lib/ovs-lldp.h

  Log Message:
  -----------
  lldp: Remove unused definitions from headers.

Signed-off-by: Ben Pfaff <blp at nicira.com>

  Commit: ac211bdd76ca8a3dd93569c7f68bbd11c0fe0190
      https://github.com/openvswitch/ovs/commit/ac211bdd76ca8a3dd93569c7f68bbd11c0fe0190
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-03-03 (Tue, 03 Mar 2015)

  Changed paths:
    M lib/lldp/lldpd.h
    M lib/ovs-lldp.h

  Log Message:
  -----------
  lldp: Fully parenthesize some macro definitions.

Signed-off-by: Ben Pfaff <blp at nicira.com>

Compare: https://github.com/openvswitch/ovs/compare/560d3df761d0...ac211bdd76ca