[ovs-git] [openvswitch/ovs] d08113: datapath: Fix return of uninitialized variable.

Thu Mar 5 07:02:06 UTC 2015

  Branch: refs/heads/ovn
  Home:   https://github.com/openvswitch/ovs
  Commit: d08113d694b9934a9207166b59f3d86fa50f07f2
      https://github.com/openvswitch/ovs/commit/d08113d694b9934a9207166b59f3d86fa50f07f2
  Author: Alex Wang <alexw at nicira.com>
  Date:   2015-02-26 (Thu, 26 Feb 2015)

  Changed paths:
    M datapath/flow_netlink.c

  Log Message:
  -----------
  datapath: Fix return of uninitialized variable.

This commit fixes a return of uninitialized variable bug.
The bug can cause failures of operations like flow_add.

VMware-BZ: #1405810

Signed-off-by: Alex Wang <alexw at nicira.com>
Acked-by: Pravin B Shelar <pshelar at nicira.com>

  Commit: 938a73dafdfb934fbae3de4358eecb28a93e5d82
      https://github.com/openvswitch/ovs/commit/938a73dafdfb934fbae3de4358eecb28a93e5d82
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-02-26 (Thu, 26 Feb 2015)

  Changed paths:
    M lib/util.c

  Log Message:
  -----------
  util: Fix typo in comment.

Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Justin Pettit <jpettit at nicira.com>

  Commit: 59f280f173d817150565010f5dc1a9301d02651b
      https://github.com/openvswitch/ovs/commit/59f280f173d817150565010f5dc1a9301d02651b
  Author: Alex Wang <alexw at nicira.com>
  Date:   2015-02-26 (Thu, 26 Feb 2015)

  Changed paths:
    M tests/test-hash.c

  Log Message:
  -----------
  test-hash: Make check_256byte_hash() test no 1-bits set case.

The test comment mentions that we will test the no 1-bits set case.
So, this commit makes sure that it is tested.

Signed-off-by: Alex Wang <alexw at nicira.com>

---
PATCH->V2:
- explain why calling set_bit128 with i or j == n_bits is okay.

  Commit: 135fec593706a47dad4a9debdd50e6c13aa06f86
      https://github.com/openvswitch/ovs/commit/135fec593706a47dad4a9debdd50e6c13aa06f86
  Author: Alex Wang <alexw at nicira.com>
  Date:   2015-02-27 (Fri, 27 Feb 2015)

  Changed paths:
    M tests/test-hash.c

  Log Message:
  -----------
  test-hash: Refine the check_256byte_hash().

This commit refines the check_256byte_hash() function by moving
some checks to outer loop.

Signed-off-by: Alex Wang <alexw at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>

  Commit: 2a638b8d22be66bb631b2273a72cd4c8451de065
      https://github.com/openvswitch/ovs/commit/2a638b8d22be66bb631b2273a72cd4c8451de065
  Author: Alex Wang <alexw at nicira.com>
  Date:   2015-02-27 (Fri, 27 Feb 2015)

  Changed paths:
    M lib/hash.h
    M tests/test-hash.c

  Log Message:
  -----------
  test-hash: Remove the check_word_hash() for hash_bytes128_cb.

The original test fails on big-endian system due to the hash function
performing not as well when input is uint32_t.  In reality, users should
only use hash_bytes128() to hash words larger than 128 bits (e.g. struct
flow).  Besides, we do check the 1-bit set case for 16 128-bit words in
following test case.  Therefore, the cleanest way to fix the failure
in big-endian system seems to be just removing the check_word_hash()
test for hash_bytes128_cb.

Signed-off-by: Alex Wang <alexw at nicira.com>
Acked-by: Ben Pfaff <blp at nicira.com>

  Commit: db7f2238278e9834e1ba526e44512ba30335075a
      https://github.com/openvswitch/ovs/commit/db7f2238278e9834e1ba526e44512ba30335075a
  Author: Joe Stringer <joestringer at nicira.com>
  Date:   2015-02-27 (Fri, 27 Feb 2015)

  Changed paths:
    M datapath/datapath.c
    M datapath/flow_netlink.c
    M datapath/flow_netlink.h

  Log Message:
  -----------
  datapath: Refactor ovs_nla_fill_match().

Refactor the ovs_nla_fill_match() function into separate netlink
serialization functions ovs_nla_put_{unmasked_key,mask}(). Modify
ovs_nla_put_flow() to handle attribute nesting and expose the 'is_mask'
parameter - all callers need to nest the flow, and callers have better
knowledge about whether it is serializing a mask or not.