[ovs-git] [openvswitch/ovs] bce01e: netdev-dpdk: Fix sparse warnings.

GitHub noreply at github.com
Tue May 19 21:51:03 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: bce01e3a89ac4b05d9e81408aa57717f2776f0be
      https://github.com/openvswitch/ovs/commit/bce01e3a89ac4b05d9e81408aa57717f2776f0be
  Author: Ethan Jackson <ethan at nicira.com>
  Date:   2015-05-19 (Tue, 19 May 2015)

  Changed paths:
    M lib/netdev-dpdk.c
    M tests/dpdk/ring_client.c

  Log Message:
  -----------
  netdev-dpdk: Fix sparse warnings.

These are all minor style issues.

Signed-off-by: Ethan Jackson <ethan at nicira.com>
Acked-by: Daniele Di Proietto <diproiettod at vmware.com>


  Commit: cd159f1a82674eca96e8e2c0f184e3abac92172d
      https://github.com/openvswitch/ovs/commit/cd159f1a82674eca96e8e2c0f184e3abac92172d
  Author: Ethan Jackson <ethan at nicira.com>
  Date:   2015-05-19 (Tue, 19 May 2015)

  Changed paths:
    M lib/dpif-netdev.c
    M lib/netdev-dpdk.c
    M lib/netdev.h

  Log Message:
  -----------
  dpdk: Ditch MAX_PKT_BURST macro.

The MAX_PKT_BURST and NETDEV_MAX_RX_BATCH macros had a confusing
relationship.  They basically purport to do the same thing, making it
unclear which is the source of truth.

Furthermore, while NETDEV_MAX_RX_BATCH was 256, MAX_PKT_BURST was 32,
meaning we never process a batch larger than 32 packets further adding
to the confusion.

This patch resolves the issue by removing MAX_PKT_BURST completely,
and shrinking the new NETDEV_MAX_BURST macro to only 32.  This should
have no change in the execution path except shrinking a couple of
structs and memory allocations (can't hurt).

Signed-off-by: Ethan Jackson <ethan at nicira.com>
Acked-by: Daniele Di Proietto <diproiettod at vmware.com>


Compare: https://github.com/openvswitch/ovs/compare/fa7de3220ce7...cd159f1a8267


More information about the git mailing list