[ovs-git] [openvswitch/ovs] 603f2c: dpif-netdev: Clear flow batches before execute.

GitHub noreply at github.com
Thu May 21 20:50:16 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 603f2ce04d000892cc4db841cff7b3b3fc95bb6c
      https://github.com/openvswitch/ovs/commit/603f2ce04d000892cc4db841cff7b3b3fc95bb6c
  Author: Ethan Jackson <ethan at nicira.com>
  Date:   2015-05-21 (Thu, 21 May 2015)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Clear flow batches before execute.

When executing actions, it's possible a recirculation will occur
causing dp_netdev_input() to be called multiple times.  If the batch
pointers embedded in dp_netdev_flow aren't cleared, it's possible
packets after the recirculation will be reinserted into a batch
associated with the original lookup.  This could be very bad.

This patch fixes the problem by zeroing out flow batch pointers before
calling packet_batch_execute().  This probably has a slightly negative
performance impact, though I haven't tried it.

Signed-off-by: Ethan Jackson <ethan at nicira.com>
Acked-by: Daniele Di Proietto <diproiettod at vmware.com>




More information about the git mailing list