[ovs-git] [openvswitch/ovs] 337c45: dpctl: Fix jump through wild pointer in "dpctl/hel...

GitHub noreply at github.com
Wed Nov 4 01:41:07 UTC 2015

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 337c452854451ed1b32d414a44c62b78b4a057c9
  Author: Ben Pfaff <blp at nicira.com>
  Date:   2015-11-03 (Tue, 03 Nov 2015)

  Changed paths:
    M lib/dpctl.c

  Log Message:
  dpctl: Fix jump through wild pointer in "dpctl/help".

dpctl_unixctl_handler() didn't fully initialize the dpctl_params structure
it passed to the handler, which meant that dpctl_help() could see a nonnull
(indeterminate) 'usage' pointer and jump through it, causes a crash.
This commit fixes the crash by fully initializing the structure.

The dpctl/help command wasn't going to do anything useful anyway, so this
commit also stops registering it.

Reported-by: Murali R <muralirdev at gmail.com>
Reported-at: http://openvswitch.org/pipermail/discuss/2015-October/019135.html
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Daniele Di Proietto <diproiettod at vmware.com>

More information about the git mailing list