[ovs-git] [openvswitch/ovs] 4b2899: dpctl: Fix jump through wild pointer in "dpctl/hel...
GitHub
noreply at github.com
Wed Nov 4 01:41:32 UTC 2015
Branch: refs/heads/branch-2.4
Home: https://github.com/openvswitch/ovs
Commit: 4b2899cc5522546c792b83e1220a7c2a00fb9918
https://github.com/openvswitch/ovs/commit/4b2899cc5522546c792b83e1220a7c2a00fb9918
Author: Ben Pfaff <blp at nicira.com>
Date: 2015-11-03 (Tue, 03 Nov 2015)
Changed paths:
M AUTHORS
M lib/dpctl.c
Log Message:
-----------
dpctl: Fix jump through wild pointer in "dpctl/help".
dpctl_unixctl_handler() didn't fully initialize the dpctl_params structure
it passed to the handler, which meant that dpctl_help() could see a nonnull
(indeterminate) 'usage' pointer and jump through it, causes a crash.
This commit fixes the crash by fully initializing the structure.
The dpctl/help command wasn't going to do anything useful anyway, so this
commit also stops registering it.
Reported-by: Murali R <muralirdev at gmail.com>
Reported-at: http://openvswitch.org/pipermail/discuss/2015-October/019135.html
Signed-off-by: Ben Pfaff <blp at nicira.com>
Acked-by: Daniele Di Proietto <diproiettod at vmware.com>
More information about the git
mailing list