[ovs-git] [openvswitch/ovs] d69d44: ofproto: Correctly reject duplicate bucket ID for ...

[GitHub]

  Branch: refs/heads/branch-2.4
  Home:   https://github.com/openvswitch/ovs
  Commit: d69d4400cdb5c0023750dbc17aed6e97b24528c8
      https://github.com/openvswitch/ovs/commit/d69d4400cdb5c0023750dbc17aed6e97b24528c8
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2015-11-25 (Wed, 25 Nov 2015)

  Changed paths:
    M AUTHORS
    M ofproto/ofproto.c
    M tests/ofproto.at

  Log Message:
  -----------
  ofproto: Correctly reject duplicate bucket ID for OFPGC_INSERT_BUCKET.

Otherwise duplicate bucket IDs cause linked list loops and other nastiness
because the ofputil_bucket_find() in the OFPG15_BUCKET_LAST case later in
copy_buckets_for_insert_bucket() will find the new bucket instead of the
old one and the list_splice() call becomes nonsensical.

Reported-by: Ray Li <rayli1107 at gmail.com>
Reported-at: http://openvswitch.org/pipermail/discuss/2015-September/018731.html
Signed-off-by: Ben Pfaff <blp at ovn.org>
Reviewed-by: Simon Horman <simon.horman at netronome.com>