[ovs-git] [openvswitch/ovs] 96cabc: AUTHORS: Update email address.

GitHub noreply at github.com
Wed Nov 25 21:54:55 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 96cabc29d29dfe4cc84385ce41f6828d9eba4fd4
      https://github.com/openvswitch/ovs/commit/96cabc29d29dfe4cc84385ce41f6828d9eba4fd4
  Author: Gurucharan Shetty <gshetty at nicira.com>
  Date:   2015-11-25 (Wed, 25 Nov 2015)

  Changed paths:
    M AUTHORS

  Log Message:
  -----------
  AUTHORS: Update email address.

Signed-off-by: Gurucharan Shetty <guru at ovn.org>


  Commit: 13165df937f24b91fc5b3c31be2f7b424eb12104
      https://github.com/openvswitch/ovs/commit/13165df937f24b91fc5b3c31be2f7b424eb12104
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2015-11-25 (Wed, 25 Nov 2015)

  Changed paths:
    M datapath-windows/ovsext/Switch.c
    M datapath-windows/ovsext/Vport.c

  Log Message:
  -----------
  datapath-windows: refactor port enumeration code

We already have functions HvCreatePort() and HvCreateNic() to
do the work. Might as well use that during port enumeration.
More refactoring in later patches.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Sairam Venugopal <vsairam at vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Signed-off-by: Gurucharan Shetty <guru at ovn.org>


  Commit: 958227c655d41821843e8d5d2b636f586b0cb5b4
      https://github.com/openvswitch/ovs/commit/958227c655d41821843e8d5d2b636f586b0cb5b4
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2015-11-25 (Wed, 25 Nov 2015)

  Changed paths:
    M datapath-windows/ovsext/Oid.c
    M datapath-windows/ovsext/Vport.c
    M datapath-windows/ovsext/Vport.h

  Log Message:
  -----------
  datapath-windows: cleanup InitHvVportCommon()

The workflow being implemented is that, we need to assign a special
name to the internal and external NICs, and it it not necessary to do
that from InitHvVportCommon(). The purpose of InitHvVportCommon() is to
insert the vport into the hash tables and update the switch context.

We special case the name assignment in HvCreateNIC() for
internal and external NICs. That seems more meaningful.

Also, reused HvCreatePort() to allocate a Vport for each of the external
NICs with NicIndex != 0. Due to this HvCreatePort() now takes 'nicIndex'
as an additional parameter.

Renamed InitHvVportCommon() to UpdateSwitchCtxWithVport().

Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Sairam Venugopal <vsairam at vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Signed-off-by: Gurucharan Shetty <guru at ovn.org>


  Commit: 9be4a8373394c3afcf80a4b02a12a914e7fc1eb9
      https://github.com/openvswitch/ovs/commit/9be4a8373394c3afcf80a4b02a12a914e7fc1eb9
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2015-11-25 (Wed, 25 Nov 2015)

  Changed paths:
    M datapath-windows/ovsext/Datapath.c
    M datapath-windows/ovsext/DpInternal.h
    M datapath-windows/ovsext/Event.c
    M datapath-windows/ovsext/Event.h
    M datapath-windows/ovsext/Switch.c
    M datapath-windows/ovsext/Vport.c

  Log Message:
  -----------
  datapath-windows: cleanup events code

Turns out that we don't need to generate an event is practically
useful only in case of a port disconnect to let userspace know.
Hence, this event is being posted from HvDisconnectNic().

In case of a new port appearing, it seems that userspace is not
interested in a new port unless it was added by userspace itself.
In my tests, userspce would end up deleting the port when it got
a new port notification, despite the port existing in OVSDB.

The reasoning seems simple enough:
- On Linux, OVS is integrated with the hypervisor (libvirt for eg)
and a port (ie. netdev) gets created in the Linux kernel and then
get added to OVSDB. When vswitchd picks up the port addition in OVSDB,
it adds the port in the OVS kernel DP.
- If the kernel netdev does not exist while OVS userspace tries to
create the port in OVS kernel DP, port addition fails. Moreover, the
only way to re-add the port is to trigger userspace to re-add the port
by deleting the port in OVSDB and re-adding it.

With this patch, I have verified that if a VIF gets disconnected on the
Hyper-V switch, it disappears from the OVS kernel DP as well.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Sairam Venugopal <vsairam at vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Signed-off-by: Gurucharan Shetty <guru at ovn.org>


  Commit: 12e888bae3b29b83d2c0877bbbfb07ce42089539
      https://github.com/openvswitch/ovs/commit/12e888bae3b29b83d2c0877bbbfb07ce42089539
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2015-11-25 (Wed, 25 Nov 2015)

  Changed paths:
    M datapath-windows/ovsext/Actions.c
    M datapath-windows/ovsext/BufferMgmt.c
    M datapath-windows/ovsext/DpInternal.h
    M datapath-windows/ovsext/IpHelper.c
    M datapath-windows/ovsext/IpHelper.h
    M datapath-windows/ovsext/Switch.c
    M datapath-windows/ovsext/User.c
    M datapath-windows/ovsext/Vport.c

  Log Message:
  -----------
  datapath-windows: nuke port # argument in IP helper

Port # doesn't make much sense since it has not been computed yet.

Also, get rid of OVS_DEFAULT_PORT_NO and use OVS_DPPORT_NUMBER_INVALID
instead.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Sairam Venugopal <vsairam at vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Signed-off-by: Gurucharan Shetty <guru at ovn.org>


  Commit: 34be96cabf1e0ef684764feaa797ee410c86b049
      https://github.com/openvswitch/ovs/commit/34be96cabf1e0ef684764feaa797ee410c86b049
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2015-11-25 (Wed, 25 Nov 2015)

  Changed paths:
    M datapath-windows/ovsext/Vport.c

  Log Message:
  -----------
  datapath-windows: cleanup AssignNicNameSpecial()

AssignNicNameSpecial() needed to be called outside of a lock and was
moved out in a previous change. But, it was accessing vport structure
outside of the lock which isn't safe. In this change, we take care of
that.

I tried to trigger a call to HvUpdateNic() by renaming the interface
from the GUI and didn't see any callback. Other changes are tested.

Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Sairam Venugopal <vsairam at vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Signed-off-by: Gurucharan Shetty <guru at ovn.org>


  Commit: d49b001d137eba8296d3f9581c91fea8067c4352
      https://github.com/openvswitch/ovs/commit/d49b001d137eba8296d3f9581c91fea8067c4352
  Author: Nithin Raju <nithin at vmware.com>
  Date:   2015-11-25 (Wed, 25 Nov 2015)

  Changed paths:
    M datapath-windows/ovsext/Vport.c
    M datapath-windows/ovsext/Vport.h

  Log Message:
  -----------
  datapath-windows: Fix HvUpdateNic() to handle name changes

If the name of an internal or external NIC changes, we need to
disconnect the NIC from OVS since the name is the key. In this
change, we generate a link down event. It is as though we got a
call to HvDisconnectNic() for the old name and got a HvConnectNic()
for the new name.

Also, HvCreateNic() has been cleaned up to remove the code to look
for existing vport. We won't have a vport now since we'd have deleted
the vport in HvDeleteNic().

Signed-off-by: Nithin Raju <nithin at vmware.com>
Acked-by: Sairam Venugopal <vsairam at vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean at cloudbasesolutions.com>
Signed-off-by: Gurucharan Shetty <guru at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/8ab5b8d6ad1a...d49b001d137e


More information about the git mailing list