[ovs-git] [openvswitch/ovs] 4f2017: ofp-actions: Look inside write_actions for output ...

GitHub noreply at github.com
Sun Nov 29 18:57:48 UTC 2015


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 4f20179ddc79843ef89f68d2c8342df0eb69a814
      https://github.com/openvswitch/ovs/commit/4f20179ddc79843ef89f68d2c8342df0eb69a814
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2015-11-29 (Sun, 29 Nov 2015)

  Changed paths:
    M AUTHORS
    M lib/ofp-actions.c
    M lib/ofp-actions.h
    M ofproto/ofproto.c
    M tests/ofproto-dpif.at

  Log Message:
  -----------
  ofp-actions: Look inside write_actions for output ports and groups.

The out_port and out_group matches only looked at apply_actions
instructions, but my interpretation of the OpenFlow spec is that they
should also look inside write_actions.

This affected the output of (and in one case the correctness of) some
tests, so this updates them.

Reported-by: Gavin Remaley <gavin_remaley at selinc.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Reviewed-by: Simon Horman <simon.horman at netronome.com>


  Commit: 6d5d1f3bb76ca76b31fa8614bb914f91aace3f52
      https://github.com/openvswitch/ovs/commit/6d5d1f3bb76ca76b31fa8614bb914f91aace3f52
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2015-11-29 (Sun, 29 Nov 2015)

  Changed paths:
    M NEWS
    M lib/ofp-parse.c
    M utilities/ovs-ofctl.8.in

  Log Message:
  -----------
  ovs-ofctl: Add "out_group" keyword for OF1.1+ matching on output group.

It seems that OVS has never supported this OpenFlow feature in ovs-ofctl,
which makes it hard to test.  This commit adds support.

(Open vSwitch has supported this in OpenFlow for a long time; it's only
ovs-ofctl that didn't.)

Signed-off-by: Ben Pfaff <blp at ovn.org>
Reviewed-by: Simon Horman <simon.horman at netronome.com>


  Commit: 71300040d1b43742eb41e1f9531f00ceed2bdae1
      https://github.com/openvswitch/ovs/commit/71300040d1b43742eb41e1f9531f00ceed2bdae1
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2015-11-29 (Sun, 29 Nov 2015)

  Changed paths:
    M tests/ofproto.at

  Log Message:
  -----------
  tests: Add tests for out_port and out_group.

Open vSwitch has supported these features on flow_mod for a long time, but
it has never included a test.  This commit adds tests for both.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Reviewed-by: Simon Horman <simon.horman at netronome.com>


Compare: https://github.com/openvswitch/ovs/compare/fb28ef2d6ef8...71300040d1b4


More information about the git mailing list