[ovs-git] [openvswitch/ovs] 68a675: ipfix: Add bridge_exporter_enabled().

GitHub noreply at github.com
Fri Sep 11 22:25:00 UTC 2015


  Branch: refs/heads/branch-2.3
  Home:   https://github.com/openvswitch/ovs
  Commit: 68a6759fc587bd896cabcdc9e7d572215480612b
      https://github.com/openvswitch/ovs/commit/68a6759fc587bd896cabcdc9e7d572215480612b
  Author: Joe Stringer <joestringer at nicira.com>
  Date:   2015-09-11 (Fri, 11 Sep 2015)

  Changed paths:
    M ofproto/ofproto-dpif-ipfix.c

  Log Message:
  -----------
  ipfix: Add bridge_exporter_enabled().

Rather than describing this intention after the fact, encode this
meaning in the name of a function.

Signed-off-by: Joe Stringer <joestringer at nicira.com>
Acked-by: Romain Lenglet <romain.lenglet at oracle.com>


  Commit: 8adb8a61f703c057d28b2e4450286c2aaecf451c
      https://github.com/openvswitch/ovs/commit/8adb8a61f703c057d28b2e4450286c2aaecf451c
  Author: Joe Stringer <joestringer at nicira.com>
  Date:   2015-09-11 (Fri, 11 Sep 2015)

  Changed paths:
    M ofproto/ofproto-dpif-ipfix.c

  Log Message:
  -----------
  ipfix: Fix SIGFPE in bridge exporter sampling.

A divide-by-zero exception like the below could occur when IPFIX
configuration is cleared while handling sampled packets from the
datapath. While it's not valid to configure the sampling probability of
IPFIX to zero via explicitly setting it in OVSDB, it is possible to
clear the configuration, which results in a probability of zero. In this
case, there is a window during which it is possible for upcalls to find
the cleared IPFIX object and attempt to perform sampling using it. Fix
the issue by ensuring that the probability is nonzero before using it.

"Program terminated with signal SIGFPE, Arithmetic exception."

dpif_ipfix_bridge_sample (...) at ../ofproto/ofproto-dpif-ipfix.c:1701
process_upcall (...) at ../ofproto/ofproto-dpif-upcall.c:1145
recv_upcalls (...) at ../ofproto/ofproto-dpif-upcall.c:705
udpif_upcall_handler (...) at ../ofproto/ofproto-dpif-upcall.c:631
ovsthread_wrapper (...) at ../lib/ovs-thread.c:340
start_thread (...) at pthread_create.c:312
clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111

Signed-off-by: Joe Stringer <joestringer at nicira.com>
Acked-by: Romain Lenglet <romain.lenglet at oracle.com>


Compare: https://github.com/openvswitch/ovs/compare/b2235a2f4d4c...8adb8a61f703


More information about the git mailing list