[ovs-git] [openvswitch/ovs] 5fb967: ipfix: Add bridge_exporter_enabled().

GitHub noreply at github.com
Fri Sep 11 22:25:07 UTC 2015


  Branch: refs/heads/branch-2.4
  Home:   https://github.com/openvswitch/ovs
  Commit: 5fb96706875346c5c9c14cea3e5163909556e1c8
      https://github.com/openvswitch/ovs/commit/5fb96706875346c5c9c14cea3e5163909556e1c8
  Author: Joe Stringer <joestringer at nicira.com>
  Date:   2015-09-11 (Fri, 11 Sep 2015)

  Changed paths:
    M ofproto/ofproto-dpif-ipfix.c

  Log Message:
  -----------
  ipfix: Add bridge_exporter_enabled().

Rather than describing this intention after the fact, encode this
meaning in the name of a function.

Signed-off-by: Joe Stringer <joestringer at nicira.com>
Acked-by: Romain Lenglet <romain.lenglet at oracle.com>


  Commit: bc031b83116f1035549ff766040f0c67ca58472d
      https://github.com/openvswitch/ovs/commit/bc031b83116f1035549ff766040f0c67ca58472d
  Author: Joe Stringer <joestringer at nicira.com>
  Date:   2015-09-11 (Fri, 11 Sep 2015)

  Changed paths:
    M ofproto/ofproto-dpif-ipfix.c

  Log Message:
  -----------
  ipfix: Fix SIGFPE in bridge exporter sampling.

A divide-by-zero exception like the below could occur when IPFIX
configuration is cleared while handling sampled packets from the
datapath. While it's not valid to configure the sampling probability of
IPFIX to zero via explicitly setting it in OVSDB, it is possible to
clear the configuration, which results in a probability of zero. In this
case, there is a window during which it is possible for upcalls to find
the cleared IPFIX object and attempt to perform sampling using it. Fix
the issue by ensuring that the probability is nonzero before using it.

"Program terminated with signal SIGFPE, Arithmetic exception."

dpif_ipfix_bridge_sample (...) at ../ofproto/ofproto-dpif-ipfix.c:1701
process_upcall (...) at ../ofproto/ofproto-dpif-upcall.c:1145
recv_upcalls (...) at ../ofproto/ofproto-dpif-upcall.c:705
udpif_upcall_handler (...) at ../ofproto/ofproto-dpif-upcall.c:631
ovsthread_wrapper (...) at ../lib/ovs-thread.c:340
start_thread (...) at pthread_create.c:312
clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111

Signed-off-by: Joe Stringer <joestringer at nicira.com>
Acked-by: Romain Lenglet <romain.lenglet at oracle.com>


Compare: https://github.com/openvswitch/ovs/compare/63b0899453da...bc031b83116f


More information about the git mailing list